Codecov Report

Merging #2232 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2232      +/-   ##
==========================================
- Coverage   52.67%   52.64%   -0.04%     
==========================================
  Files         237      237              
  Lines       14744    14747       +3     
==========================================
- Hits         7766     7763       -3     
- Misses       6978     6984       +6

args.url can be None, but never when launching the player, so I think you'd be OK here.

plugin.url is also available there, instead of args.url

I haven't seen any problems using url=args.url.

Do urls get unshortened, E.g. bitly, when using args.url?

No, with args.url they do not. With plugin.url they do. So I guess plugin.url is more robust.

Another thing I noticed when using plugin.url is that now every URL has a scheme http:// prefixed. That might not be the most readable representation. Maybe we should drop the scheme for title using:

url=''.join(urlsplit(plugin.url)[1:])

I guess something like

parsed = urlparse(url)
scheme = "%s://" % parsed.scheme
return parsed.geturl().replace(scheme, '', 1)

would be more robust at dropping the scheme.

probably also okay with the url scheme

@back-to Do you mean it's fine as a raw URL or should I implement scheme dropping?