cli.argparser: Fix single hyphen params at the beginning of --player-args #2333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…args use workaround solution from https://bugs.python.org/issue9334 don't know if there is any downside, but seems like it could work it can be reversed, if there are some issue closes streamlink#971
Codecov Report
@@ Coverage Diff @@
## master #2333 +/- ##
==========================================
+ Coverage 52.59% 52.61% +0.01%
==========================================
Files 237 237
Lines 14797 14811 +14
==========================================
+ Hits 7783 7793 +10
- Misses 7014 7018 +4 |
|
Is this compatible with all versions? |
|
@bastimeyer |
|
I was just wondering because all that's being tested here is this special case and not the entire argparser testsuite. Just had a look at it again and didn't realize that all that was added here is the first |
|
as you are fine with it @bastimeyer , |
mkbloke
pushed a commit
to mkbloke/streamlink
that referenced
this pull request
Aug 18, 2020
cli.argparser: Fix single hyphen params at the beginning of --player-args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use workaround solution from
https://bugs.python.org/issue9334
don't know if there is any downside,
but seems like it could work
it can be reversed, if there are some issue
closes #971