Skip to content

http server binds to all hosts rather than localhost #2622

@alok0

Description

@alok0

Issue

  • This is not a bug report, feature request, or plugin issue/request.
  • I have read the contribution guidelines.

Description

Not specifying player-external-http does not stop streamlink from listening on all interfaces.

This causes a problem on a system where interfaces might change or go down while streamlink is running, where somehow streamlink has passed an ip other than 127.0.0.1 to the player

Expected / Actual behavior

according to the documentation for player-external-http

the server will listen on all available connections instead of just in the local (loopback) interface.

according to the comments create_http_server in main.py

If host is empty, listen on all available interfaces,

which it does do, and in turn when not in external mode, the http server is still listening on all interfaces.

Reproduction steps / Explicit stream URLs to test

Logs

Additional comments, screenshots, etc.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions