Skip to content

cli: optional player-args input variable #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bastimeyer
Copy link
Member

  • Make the player input variable in the --player-args parameter
    optional. If it's missing, append it to the parameter value.
  • Rename it from {filename} to {playerinput}, to reduce confusion
    and add {filename} back as a secondary fallback variable.
  • Update parameter docs accordingly and add+fix tests

See: #2947

- Make the player input variable in the `--player-args` parameter
  optional. If it's missing, append it to the parameter value.
- Rename it from `{filename}` to `{playerinput}`, to reduce confusion
  and add `{filename}` back as a secondary fallback variable.
- Update parameter docs accordingly and add+fix tests
@gravyboat
Copy link
Member

Looks good, thanks!

@gravyboat gravyboat merged commit ea703e3 into streamlink:master Oct 31, 2020
@bastimeyer bastimeyer deleted the feature/implicit-player-args-variable branch January 19, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants