Skip to content

stream.ffmpegmux: disable -start_at_zero for -copyts as default #3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

back-to
Copy link
Collaborator

@back-to back-to commented Dec 13, 2020


as this might have some downsides

Might be helpful for #3404

- don't use `-start_at_zero` as default for `-copyts`
- revert streamlink#2559

- change command `--ffmpeg-no-start-at-zero` to `--ffmpeg-start-at-zero`
  (there was no release in between this command)

- use `--ffmpeg-start-at-zero` for the facebook plugin,
  because the original fix was for it.
  streamlink#2488
Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looking good. One thing to note though: ffmpeg-start-at-zero on the session should default to False, not to None. It's already documented as bool.

@back-to back-to merged commit 37bd9fc into streamlink:master Dec 15, 2020
@back-to back-to deleted the start_at_zero branch December 15, 2020 15:57
Billy2011 pushed a commit to Billy2011/streamlink-27 that referenced this pull request Dec 15, 2020
…lt (streamlink#3413)

- don't use `-start_at_zero` as default for `-copyts`
- revert streamlink#2559

- change command `--ffmpeg-no-start-at-zero` to `--ffmpeg-start-at-zero`
  (there was no release in between this command)

- use `--ffmpeg-start-at-zero` for the facebook plugin,
  because the original fix was for it.
  streamlink#2488
@bastimeyer
Copy link
Member

Just for reference, --ffmpeg-no-start-at-zero was added in #2892

Billy2011 pushed a commit to Billy2011/streamlink-27 that referenced this pull request Dec 17, 2020
…lt (streamlink#3413)

- don't use `-start_at_zero` as default for `-copyts`
- revert streamlink#2559

- change command `--ffmpeg-no-start-at-zero` to `--ffmpeg-start-at-zero`
  (there was no release in between this command)

- use `--ffmpeg-start-at-zero` for the facebook plugin,
  because the original fix was for it.
  streamlink#2488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants