stream.hls: remove --hls-segment-ignore-names command #3414
Conversation
It has some downsides such as `--hls-timeout`, Plugin specified FilteredHLSStream should be used instead. streamlink#3187 --- Afreeca Plugin as an Example streamlink#3408 --- Revert streamlink#1432
There was a problem hiding this comment.
I agree with the removal of this feature.
However, would it maybe make more sense merging the FilteredHLS logic into the regular HLS classes instead? By doing this, we could keep the CLI argument and custom filtering feature. The drawback would be the need of refactoring the regular HLS classes a bit and making it a bit more slow due to the additional filtering checks on each write call, which was the reason why I implemented this separately. The classes which depend on FilteredHLS also need to get refactored, which is currently only the HLSStream stuff of the Twitch plugin (and AfreecaTV once that PR gets merged).
maybe, but probably to much work for streamlink 2.0.0 Ref #2497 |
|
I don't think it's too much work. If we keep the filtered tests separated from the other HLS tests, it should be pretty simple. Let me give this a try... |
It has some downsides such as
--hls-timeout,Plugin specified FilteredHLSStream should be used instead.
#3187
Afreeca Plugin as an Example
#3408
Revert #1432