Skip to content

add --niconico-timeshift-offset option to the nicolive plugin #3425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2020

Conversation

mark-ignacio
Copy link
Contributor

--niconico-timeshift-offset allows the nicolive Streamlink plugin to start at a particular timestamp in the HLS stream for timeshift streams.

This proves particularly useful because some broadcasts' HLS streams start with a long "waiting room" during a live broadcast that the web player skips past by default.

offset = self.get_option("timeshift-offset")
if offset:
if 'timeshift' in self.wss_api_url:
self.hls_stream_url += '&start={0}'.format(offset)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 258 to 260
_log.debug("Timeshift offset stream URL is now {0}".format(self.hls_stream_url))
else:
_log.debug("Not a timeshift video, ignoring offset")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need this

@@ -241,6 +250,14 @@ def handle_api_message(self, message):
if message_parsed["type"] == "stream":
data = message_parsed["data"]
self.hls_stream_url = data["uri"]
# load in the offset for timeshift live videos
offset = self.get_option("timeshift-offset")
if offset:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

            if offset and 'timeshift' ...

@back-to back-to added the plugin enhancement A new feature for a working Plugin label Dec 20, 2020
@mark-ignacio mark-ignacio requested a review from back-to December 20, 2020 17:19
@back-to back-to merged commit 9077e2f into streamlink:master Dec 20, 2020
Billy2011 pushed a commit to Billy2011/streamlink-27 that referenced this pull request Dec 21, 2020
…eamlink#3425)

--niconico-timeshift-offset allows the nicolive Streamlink plugin to start at a particular timestamp in the HLS stream for timeshift streams.

http://help.nicovideo.jp/live_en/2013/06/305what-is-a-timeshiftwatch-period.html

This proves particularly useful because some broadcasts' HLS streams start with a long "waiting room" during a live broadcast that the web player skips past by default.
Billy2011 pushed a commit to Billy2011/streamlink-27 that referenced this pull request Dec 22, 2020
…eamlink#3425)

--niconico-timeshift-offset allows the nicolive Streamlink plugin to start at a particular timestamp in the HLS stream for timeshift streams.

http://help.nicovideo.jp/live_en/2013/06/305what-is-a-timeshiftwatch-period.html

This proves particularly useful because some broadcasts' HLS streams start with a long "waiting room" during a live broadcast that the web player skips past by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin enhancement A new feature for a working Plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants