Fix race conditions in filtered HLSStreamWriter tests #3454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- immediately set read_once event in HLSStreamReadThread - rename _TestSubjectHLSStreamWriter to EventedHLSStreamWriter - move EventedHLSStreamWriter and await_write from test_hls_filtered to stream_hls test mixin - add write_calls and timeout parameters to await_write - await all writer calls in TestTwitchHLSStream
bastimeyer
added
bug
tests
WIP
|
This should be good to go I think. I've tagged the WIP tag earlier today because I was checking something related to requests_mock in the HLS tests, but it's not worth the effort and the current changes are good enough. As said, the tests should now be reliable. |
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 28, 2020
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 28, 2020
- immediately set read_once event in HLSStreamReadThread - rename _TestSubjectHLSStreamWriter to EventedHLSStreamWriter - move EventedHLSStreamWriter and await_write from test_hls_filtered to stream_hls test mixin - add write_calls and timeout parameters to await_write - await all writer calls in TestTwitchHLSStream streamlink#3454 patches for test_hls_filtered not yet applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3451
Changes are split into two commits:
HLSStreamReaderinHLSStream.open()This explicitly awaits all writer calls in filtered HLS tests, like the Twitch HLS tests for example.
I've been running all HLS tests in a loop for almost an hour now without any failures, so I think this should be good.