Skip to content

plugins.picarto: rewrite/fix #3661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2021
Merged

plugins.picarto: rewrite/fix #3661

merged 2 commits into from
Apr 5, 2021

Conversation

mkbloke
Copy link
Member

@mkbloke mkbloke commented Mar 31, 2021

closes #3647

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Apr 1, 2021
Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the time to review this now, but the websocket logic needs to be refactored at some point. For anything HTTP related we have the HTTPSession, but the websocket stuff gets duplicated here for the fourth time, and this is a problem.

@mkbloke
Copy link
Member Author

mkbloke commented Apr 1, 2021

OK. I guess the WS stuff is just something to be added to the TODO list at some point in the future...

@mkbloke mkbloke force-pushed the picarto branch 3 times, most recently from 28bac20 to 66d9976 Compare April 3, 2021 03:52
@back-to back-to merged commit 1baa545 into streamlink:master Apr 5, 2021
@mkbloke mkbloke deleted the picarto branch April 5, 2021 09:33
Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request Apr 6, 2021
Co-authored-by: back-to <backto@protonmail.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin issue A Plugin does not work correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugins.picarto: 405 Client Error: Not Allowed for url: https://picarto.tv/process/channel
3 participants