plugins.youtube: fix consent dialog #3672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
reviewed
Apr 3, 2021
There was a problem hiding this comment.
This always sends a GET request to the input URL twice, first for the redirection check (and the POST afterwards) and then regularly in _find_video_id, even if there's no redirection to the consent page. If there's always a consent confirmation which I'm not sure about, then it's not a problem, but if not then it's redundant and unnecessarily delays the resolving of the stream data.
bastimeyer
requested changes
Apr 3, 2021
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Apr 4, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3668