revert: stream.hls: remove hls-segment-stream-data option #4159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ccdd84b - resolve merge conflicts - keep stream=False parameter in HLSStreamWriter.fetch_map - keep updated help text of --twitch-low-latency
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Nov 10, 2021
…reamlink#4159) This reverts commit ccdd84b - resolve merge conflicts - keep stream=False parameter in HLSStreamWriter.fetch_map - keep updated help text of --twitch-low-latency
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Nov 10, 2021
…reamlink#4159) This reverts commit ccdd84b - resolve merge conflicts - keep stream=False parameter in HLSStreamWriter.fetch_map - keep updated help text of --twitch-low-latency
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ccdd84b
closes #4126
closes #4146
Let's temporarily revert ccdd84b until a fix has been found for the segment request issues when
streamis set toTrue.See #4126 (comment)
TL;DR
Add back the suppressed
--hls-segment-stream-dataCLI parameter (and its according session option), with default value ofFalse, so that HLS segments don't get downloaded withstream=Trueby default, which is causing issues since the 2.4.0 release.