Skip to content

ci: fix github deploy config #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2022
Merged

ci: fix github deploy config #4503

merged 1 commit into from
May 1, 2022

Conversation

bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented May 1, 2022 •
edited
Loading

Fixes #4502

The unnoticed mistake was that BASH doesn't match anything in brace expansions if there's only one element.

$ bash -c 'ls dist/*{.tar.gz}'
ls: cannot access 'dist/*{.tar.gz}': No such file or directory

$ bash -c 'ls dist/*{.tar.gz,.exe}'
ls: cannot access 'dist/*.exe': No such file or directory
 dist/streamlink-4.0.0.tar.gz

$ bash -c 'shopt -s nullglob; ls dist/*{.tar.gz,.exe}'
dist/streamlink-4.0.0.tar.gz

As an alternative to this PR, I've got #4497 pretty much ready and validated multiple test releases in my test-repo using my test-account, but just apply this simple fix here and release 4.0.1.

Issue was introduced by #4405:
2dd2f35#diff-7829468e86c1cc5d5133195b5cb48e1ff6c75e3e9203777f6b2e379d9e4882b3R153

@bastimeyer bastimeyer merged commit a081f3a into streamlink:master May 1, 2022
@bastimeyer bastimeyer deleted the ci/fix-github-deloy branch May 1, 2022 13:16
@bastimeyer bastimeyer mentioned this pull request May 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

source-dist is missing from GitHub release
1 participant
@bastimeyer