-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs: update windows binaries section #4581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d306fad
to
bea495a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @bastimeyer. Minor question around whether links should go directly to the releases page or not, but I'm marking this as approved. If you disagree merge whenever.
@@ -326,62 +326,45 @@ optional `FFmpeg`_ Required for `muxing`_ multiple video/audio/ | |||
Windows binaries | |||
---------------- | |||
|
|||
Since late March 2022, Windows installers for Streamlink can be found at the `streamlink/windows-installer`_ repository | |||
on GitHub, with support for different architectures and different Python versions. | |||
Windows installers and portable builds for Streamlink can be found at `streamlink/windows-builds`_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this link to the releases page? Maybe I'm over thinking it but some people may get confused by not knowing where to go from this link or the others above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My intention was to only link to the releases page in the "stable" subsection below because of the distinction between stable and nightly builds. This here should therefore just link to the repo. The repo's readme also links to the releases page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
I tested the new portable win 4.20 release and works OK. Thanks a lot! |
Resolves #4579
This removes beardypig's portable builds from the docs, reformats the windows binaries section and it updates the links/anchors at the top (the sub-sections got renamed).