plugins: remove common_jwplayer module #4733
Merged
+0
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #4718, this module has been rotting in the plugins package for several years and should be removed.
It was added in d499a48 back in 2014 and was used by the following plugins
The docs's plugins extension and the generic plugins tests still have checks for modules inside the plugins package whose file name starts with
common_
, but those checks don't necessarily have to be removed with the removal of the (last)common_
module:streamlink/docs/ext_plugins.py
Lines 184 to 190 in 156b660
streamlink/tests/test_plugins.py
Lines 27 to 31 in 156b660