Skip to content

plugins: remove common_jwplayer module #4733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Aug 14, 2022

As mentioned in #4718, this module has been rotting in the plugins package for several years and should be removed.
It was added in d499a48 back in 2014 and was used by the following plugins

  • connectcast (removed plugin in 6571b28)
  • euronews (updated in 777a96f)
  • sportal (updated in a91e134)
  • tv5monde (removed plugin in 3c85180, reimplemented plugin without common_jwplayer in b3efc27)
$ git log --format=reference -S common_jwplayer -- src/
3c851805 (plugins.tv5monde: remove plugin, 2021-10-07)
57eea0fb (plugins.sportal: Removed old RTMP streams, use HLS, 2018-08-04)
e50e60b2 (Add support for TV5Monde, 2017-06-02)
8329f701 (plugins.sportal: added support for the live stream on sportal.bg, 2017-01-10)
777a96f9 (plugins.euronew: update to support the new site (#141), 2016-11-08)
30fb8623 (Fix connectcast.tv livestreaming, 2015-02-01)
dca69a2a (plugins.euronews: Update for service changes., 2014-09-03)
d499a488 (plugins.connectcast: Move JWPlayer playlist parsing to support plugin., 2014-09-03)

The docs's plugins extension and the generic plugins tests still have checks for modules inside the plugins package whose file name starts with common_, but those checks don't necessarily have to be removed with the removal of the (last) common_ module:

  • def __init__(self):
    plugins_path = Path(streamlink_plugins.__path__[0])
    self.plugins = [
    (pname, plugins_path / f"{pname}.py")
    for finder, pname, ispkg in pkgutil.iter_modules([str(plugins_path)])
    if not pname.startswith("common_") and pname not in self.protocol_plugins
    ]
  • plugins = [
    pname
    for finder, pname, ispkg in pkgutil.iter_modules([plugins_path])
    if not pname.startswith("common_")
    ]

@bastimeyer bastimeyer mentioned this pull request Aug 14, 2022
@gravyboat gravyboat merged commit 1dd07f6 into streamlink:master Aug 14, 2022
@bastimeyer bastimeyer deleted the plugins/common-jwplayer/remove branch August 14, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants