plugins.tvp: rewrite and fix plugin, add VODs #4905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
new plugin works. |
|
Tested, works. |
bastimeyer
force-pushed
the
plugins/tvp/rewrite
branch
from
e32d2da to
55e56e4
Compare
|
Added support for VODs: Authentication won't be supported though and the URL matcher is technically not 100% correct and could lead to 403 error responses from the API if a URL of a show instead of an episode was set. Since some shows/films/whatever don't have episodes and use the same URL format, this couldn't be fixed easily. Most VODs are also geo-blocked, so 403 errors will also be shown in those cases. VOD with episode Invalid URL Geo-blocked |
bastimeyer
changed the title
|
VOD works as excepted. Geo-blocked works in Poland. |
bastimeyer
force-pushed
the
plugins/tvp/rewrite
branch
from
55e56e4 to
a27861b
Compare
bastimeyer
force-pushed
the
plugins/tvp/rewrite
branch
from
a27861b to
224bc55
Compare
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Nov 5, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4904
The old URLs get properly redirected, so I kept them in the plugin matcher regex.
When retrieving the video ID, the
Connection: closeheader had to be set, because otherwise, the server would abort the next request for some reason. Took me a bit figure out, because I couldn't observe the behavior in my web browser or via curl, and it wasn't caused by session data like cookies, etc. Also had a look at urllib3's connection pool, but setting the header seems to work and is far easier than trying to close any connections in the connection pool, which is a private low-level API call anyway and probably not wise to use.