build: add urllib3 directly and set it to >=1.26.0 #4950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streamlink currently sets the version range of its `requests` dependency to `>=2.26.0,<3.0`. `requests` however still defines its `urllib3` dependency version range as `>=1.21.1,<1.27` in its `2.26.0`-`2.28.1` releases, including its current state in git. Recent fixes in Streamlink's HLS implementation unfortunately were made with methods which are only supported by `urllib3 >=1.26.0`. This obviously breaks installs with older versions of `urllib3` installed which are still supported by the defined version range. In order to avoid having to backport more `urllib3` stuff, moving it from a transitive dependency and defining it as a direct dependency with a specific version range set to `>=1.26.0` makes more sense when fixing the issue. This doesn't conflict with the version range defined by `requests` and forces a bump of old installs of `urllib3`. `urllib3==1.26.0` was released on 2020-11-10, whereas `requests==2.26.0`, was released on 2021-07-13, the lowest version of the version range defined by Streamlink. --- In addition to defining the direct `urllib3` dependency, also remove old compatibility workarounds/bugfixes from `plugin.api.http_session`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamlink currently sets the version range of its
requestsdependency to>=2.26.0,<3.0.requestshowever still defines itsurllib3dependency version range as>=1.21.1,<1.27in its2.26.0-2.28.1releases, including its current state in git.Recent fixes in Streamlink's HLS implementation unfortunately were made with methods which are only supported by
urllib3 >=1.26.0. This obviously breaks installs with older versions ofurllib3installed which are still supported by the defined version range.In order to avoid having to backport more
urllib3stuff, moving it from a transitive dependency and defining it as a direct dependency with a specific version range set to>=1.26.0makes more sense when fixing the issue. This doesn't conflict with the version range defined byrequestsand forces a bump of old installs ofurllib3.urllib3==1.26.0was released on 2020-11-10, whereasrequests==2.26.0, was released on 2021-07-13, the lowest version of the version range defined by Streamlink.In addition to defining the direct
urllib3dependency, also remove old compatibility workarounds/bugfixes fromplugin.api.http_session.Resolves #4938