docs: rewrite Windows + AppImage install sections #4999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing python header files is only relevant when building dependencies with Python C extensions from source, like lxml or pycryptodome, which is out of scope of the Streamlink docs.
The docs should be as explicit as possible, but this might confuse inexperienced users, so an explanation might be useful.
|
Looks good. |
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 10, 2022
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially wanted to only update the AppImage section of the install docs, but then decided to also update the Windows binaries section and do some additional cleanup.
The main focus is to make finding the important information easier and quicker. This also involves adding an icon to the download links.
The third commit is not really important and could be ignored if anyone feels like it's unnecessary.