-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
plugins.ceskatelevize: update for ct24, sport and sportplus; add decko #5063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pluginmatcher should be changed.
First, https://www.ceskatelevize.cz/#live
is an invalid link, and second, https://ct24.ceskatelevize.cz/
should work without the URL hash, as it doesn't change anything in regards to the initial HTTP request of the plugin.
Also, those do not match (which are links from the channel selection dropdown):
https://sport.ceskatelevize.cz/zive-vysilani#live
https://decko.ceskatelevize.cz/zive
(ignore this if you don't want to support this channel)
Just split the pluginmatcher into multiple ones if you already need to make a distinction between regular channels and special case channels. Then check which matcher matched.
Hi Guys, unfortunately I wasn't able to get it to work. I am probably not much of a help here as I am either doing something wrong or used the wrong plugin or so... root@gbquad4k:~# /usr/sbin/streamlinksrv manualstart debug |
Thanks for trying. I'd forgotten you were using streamlinksrv. I'll get the plugin working under Streamlink, but what you are running and the Streamlink version in use is an unknown for us, that we cannot support. When the plugin is working and merged into Streamlink master, you might have to contact the maintainers of streamlinksrv to get it working for you. |
As you can see, the plugin was sideloaded by the Streamlink session instance.
This, however, is not a Streamlink issue. You are using a third party project which embeds/implements Streamlink, and we don't support that here. One hint, |
This is a deprecated path, btw. The actual plugin path is |
"When the plugin is working and merged into Streamlink master, you might have to contact the maintainers of streamlinksrv to get it working for you." That's what I am going to to in case it is needed. |
226b922
to
2ee7308
Compare
Sorry for the delay. I have fixed it up now, so I think everything should be resolved. I've added support for Decko and the sometimes on-air SportPlus (ct29). When SportPlus isn't on-air |
2ee7308
to
08beb93
Compare
One thing about matching on the subdomain is that you need to follow the redirect first, as Sport and Decko are both linked from I've also had to modify the schema for off-air channels to accommodate different responses. I see right now there are even more SportPlus channels: ct25; ct28; ct29; ct31 and ct32 all linked off Given all of the above, I've just tagged this as WIP for now. |
08beb93
to
5797222
Compare
Does not look to be so.
All tested and working as far as I can tell (the manifest is returned, but the geo-restriction means I couldn't test full streaming). |
I'll have another look later today. Thanks for the updates. |
Geo-restricted streams sometimes seem to fail instead of showing the geo-restriction video:
I can't see anything in the API responses or any HTTP response headers which would indicate geo-restriction, so there's probably not much that can be done plugin-wise. This looks more like an issue with the DASH implementation, which kills the ffmpeg process to early. Other than that, the plugin should be fine. |
While testing with a Czech VPN, the sports stream didn't seem to work:
The result is a 404 response if the |
5797222
to
2aff37e
Compare
ct1, ct2 streams nor working |
You are commenting on a merged pull request. Open a new plugin issue and fill in all the required details. |
@duunsupen, could you check this is working for all channels by sideloading the updated plugin, please? I think it's probably working OK, but they seem to detect VPS based proxies, so I just get the short clip telling me the channel isn't available for all except CT24.
For some reason, the subdomains are both different to the main channels in terms of HTML and JSON data, and different to each other as well. The API response is slightly different for
sport
too. All a bit strange.I didn't bother going through the process of finding the id for CT24, as it seems unlikely it'll change.
I notice that sometimes the streaming URL gets an empty response, but it seems intermittent. I've seen that happen in the web browser too via the network tab on the dev console.
closes #5055