Skip to content

stream.dash: fix missing initialization byterange #5189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

bastimeyer
Copy link
Member

Fixes #4215

@bastimeyer
Copy link
Member Author

The DASH spec also talks about a specific range format on the BaseURL tag with the $start$ and $end$ variables, but according to a thread on the DASH-IF feedback issue tracker, this is considered deprecated.

Also not sure why the byterange (previously range) attribute of each Segment is stored as (start,length) instead of (start,end). The length format comes from the HLS spec (length@offset), but DASH keeps the same format as the HTTP Range header, namely start-end, so the conversion that is done by the parser and fetch() method later on is actually totally unnecessary. It could be changed later, but not really important now.

@gravyboat gravyboat merged commit 07bd742 into streamlink:master Feb 22, 2023
@bastimeyer bastimeyer deleted the stream/dash/byterange branch February 22, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stream.dash: range attribute in initialization segment
2 participants