stream.dash: fix segment availability times #5213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The segment availability "anchor time" depends on the sum of the manifest's `availabilityStartTime` and the period's `start` attribute, for both static and dynamic manifests. Fix segment availability times: - Set the correct `available_at` value for static manifests with segment templates and segment timelines instead of using the current time - Set the `available_at` value for `SegmentList` segments instead of defaulting to `EPOCH_START` - Set the `available_at` value for all initialization segments Fix segment numbers: - The number offset now also takes the period start into consideration Also: - Allow passing keywords to child node constructors - Keep the `Period` reference on `SegmentList`, `SegmentTemplate` and `Representation` - Check segment availability times in certain tests - Rename DASH manifest fixture files of updated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The segment availability "anchor time" depends on the sum of the manifest's
availabilityStartTimeand the period'sstartattribute, for both static and dynamic manifests.Fix segment availability times:
available_atvalue for static manifests with segment templates and segment timelines instead of using the current timeavailable_atvalue forSegmentListsegments instead of defaulting toEPOCH_STARTavailable_atvalue for all initialization segmentsFix segment numbers:
Also:
Periodreference onSegmentList,SegmentTemplateandRepresentationThese are just minor fixes because the period start time of the first period (which we only support anyway) is zero most of the time.
The segment number fix is a "side-effect" of this PR. However, it's not a full fix and there's still something wrong with the offset calculation.