Skip to content

stream.dash: refactor DASHStream.parse_manifest() #5224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bastimeyer
Copy link
Member

No description provided.

- Move MPD manifest fetching+parsing logic to separate methods
- Rewrite tests based on pytest
- Add `period` parameter to `DASHStream.parse_manifest()`:
  This can be used by the DASH plugin, where parameters can be passed
  from the input URL
- Remove `period` parameter from the `DASHStream` constructor
  and reference the period from the chosen `Representation`
- Move `get_representation()` from `DASHStreamWorker` to `MPD`
- Update tests
@gravyboat gravyboat merged commit 4ed7be9 into streamlink:master Mar 7, 2023
@bastimeyer bastimeyer deleted the stream/dash/refactor-parse-manifest branch March 7, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants