Skip to content

Drop support for Python 3.7 #5302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 2, 2023
Merged

Conversation

bastimeyer
Copy link
Member

Opening this early as a draft.

py37 will see its EOL in about 2 months, on 2023-06-27
https://endoflife.date/python

The changes of this PR include:

  1. Official removal of py37 support from the package metadata and docs, as well as updates to the CI config
  2. Tooling config updates (mypy / ruff)
  3. Removal of compat imports
  4. Language/grammar updates of previously annotated stuff

This will obviously be a breaking change, so ideally, other breaking changes should be included in that release.


Additional tasks after merging these changes:

  • Class/function signature changes with positional-only / keyword-only parameters (py38):
    Perfect opportunity to fix some old issues with certain public APIs, e.g. HLSStream.parse_variant_playlist(), and more.

Everything else in regards to py38 can be done gradually over time later.
https://docs.python.org/3/whatsnew/3.8.html

@bastimeyer bastimeyer marked this pull request as ready for review June 26, 2023 14:40
@bastimeyer bastimeyer mentioned this pull request Jun 27, 2023
8 tasks
@bastimeyer bastimeyer merged commit e91b965 into streamlink:master Jul 2, 2023
@bastimeyer bastimeyer deleted the drop-py37 branch July 2, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant