Skip to content

plugins.mitele: fix missing CDN token #5436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2023
Merged

plugins.mitele: fix missing CDN token #5436

merged 1 commit into from
Jul 12, 2023

Conversation

bastimeyer
Copy link
Member

Fixes #5435

One of the items of the CDN-token API response was empty which led to the 403 HTTP response (since the plugin yields all possible streams). This simply skips items with empty CDN-tokens.

@ROBGagn please check and verify
https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback

$ streamlink -l debug --http-proxy=... https://www.mitele.es/directo/boing
[cli][debug] OS:         Linux-6.3.12-1-git-x86_64-with-glibc2.37
[cli][debug] Python:     3.11.3
[cli][debug] Streamlink: 5.5.1+106.g31d038d2
[cli][debug] Dependencies:
[cli][debug]  certifi: 2023.5.7
[cli][debug]  isodate: 0.6.1
[cli][debug]  lxml: 4.9.3
[cli][debug]  pycountry: 22.3.5
[cli][debug]  pycryptodome: 3.18.0
[cli][debug]  PySocks: 1.7.1
[cli][debug]  requests: 2.31.0
[cli][debug]  trio: 0.22.1
[cli][debug]  trio-websocket: 0.10.3
[cli][debug]  typing-extensions: 4.7.1
[cli][debug]  urllib3: 2.0.3
[cli][debug]  websocket-client: 1.6.1
[cli][debug] Arguments:
[cli][debug]  url=https://www.mitele.es/directo/boing
[cli][debug]  --loglevel=debug
[cli][debug]  --player=mpv
[cli][debug]  --http-proxy=...
[cli][info] Found matching plugin mitele for URL https://www.mitele.es/directo/boing
[utils.l10n][debug] Language code: en_US
[utils.l10n][debug] Language code: en_US
[utils.l10n][debug] Language code: en_US
[utils.l10n][debug] Language code: en_US
[utils.l10n][debug] Language code: en_US
[utils.l10n][debug] Language code: en_US
Available streams: none_150k, 360p_620k_alt2 (worst), 360p_620k_alt, 360p_620k, 360p_1100k_alt2, 360p_1100k_alt, 360p_1100k, 576p_1900k_alt2, 576p_1900k_alt, 576p_1900k, 720p_3400k_alt2, 720p_3400k_alt, 720p_3400k, 720p_4800k_alt2, 720p_4800k_alt, 720p_4800k (best)

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Jul 12, 2023
@ROBGagn
Copy link

ROBGagn commented Jul 12, 2023

Getting the same :

streamlink.exe -l debug https://www.mitele.es/directo/boing/
[cli][debug] OS: Windows 10
[cli][debug] Python: 3.11.3
[cli][debug] Streamlink: 5.5.1
[cli][debug] Dependencies:
[cli][debug] certifi: 2023.5.7
[cli][debug] isodate: 0.6.1
[cli][debug] lxml: 4.9.2
[cli][debug] pycountry: 22.3.5
[cli][debug] pycryptodome: 3.17
[cli][debug] PySocks: 1.7.1
[cli][debug] requests: 2.29.0
[cli][debug] urllib3: 1.26.15
[cli][debug] websocket-client: 1.5.1
[cli][debug] Arguments:
[cli][debug] url=https://www.mitele.es/directo/boing/
[cli][debug] --loglevel=debug
[cli][debug] --ffmpeg-ffmpeg=C:\Program Files\Streamlink\ffmpeg\ffmpeg.exe
[cli][info] Found matching plugin mitele for URL https://www.mitele.es/directo/boing/
[utils.l10n][debug] Language code: fr_FR
[utils.l10n][debug] Language code: fr_FR
error: Unable to open URL: https://livek.mediaset.es/orilinear31/live/linear31/playlist/playlist.isml/ctv.m3u8 (403 Client Error: Missing hdnts for url: https://livek.mediaset.es/orilinear31/live/linear31/playlist/playlist.isml/ctv.m3u8)

@bastimeyer
Copy link
Member Author

[cli][debug] Streamlink: 5.5.1

Because you are not using the right version as you can clearly see in the debug log and you're also not sideloading the updated plugin either...

I'm going to merge this now since I don't want to waste both our time.

@bastimeyer bastimeyer merged commit 15c9502 into streamlink:master Jul 12, 2023
@bastimeyer bastimeyer deleted the plugins/mitele/fix-missing-cdn-token branch July 12, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
plugin issue A Plugin does not work correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugins.mitele: 403 Client Error: Missing hdnts for url
2 participants
@bastimeyer @ROBGagn