Skip to content

plugins.huya: force https stream URLs #5467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

bastimeyer
Copy link
Member

ref #5466

Doesn't hurt and don't see any issues. No idea why their API returns non-TLS URLs, but since it's a progressive HTTP stream, I'm not even wondering...

$ streamlink -l debug https://www.huya.com/476318 best
[cli][debug] OS:         Linux-6.4.6-1-git-x86_64-with-glibc2.37
[cli][debug] Python:     3.11.3
[cli][debug] Streamlink: 6.0.0+4.gca4ca90c
[cli][debug] Dependencies:
[cli][debug]  certifi: 2023.7.22
[cli][debug]  isodate: 0.6.1
[cli][debug]  lxml: 4.9.3
[cli][debug]  pycountry: 22.3.5
[cli][debug]  pycryptodome: 3.18.0
[cli][debug]  PySocks: 1.7.1
[cli][debug]  requests: 2.31.0
[cli][debug]  trio: 0.22.2
[cli][debug]  trio-websocket: 0.10.3
[cli][debug]  typing-extensions: 4.7.1
[cli][debug]  urllib3: 2.0.4
[cli][debug]  websocket-client: 1.6.1
[cli][debug] Arguments:
[cli][debug]  url=https://www.huya.com/476318
[cli][debug]  stream=['best']
[cli][debug]  --loglevel=debug
[cli][debug]  --player=mpv
[cli][info] Found matching plugin huya for URL https://www.huya.com/476318
[plugins.huya][debug] QUALITY_WEIGHTS: {'source_al': 30, 'source_tx': 20, 'source_hw': 20, 'source_hs': 30}
[cli][info] Available streams: source_tx (worst), source_hw, source_al, source_hs (best)
[cli][info] Opening stream: source_hs (http)
[cli][info] Starting player: mpv
[cli][debug] Pre-buffering 8192 bytes
[cli.output][debug] Opening subprocess: ['/usr/bin/mpv', '--force-media-title=https://www.huya.com/476318', '-']
[cli][debug] Writing stream to output
[cli][info] Player closed
[cli][info] Stream ended
[cli][info] Closing currently open stream...

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Jul 29, 2023
@gravyboat gravyboat merged commit e83e095 into streamlink:master Jul 30, 2023
@bastimeyer bastimeyer deleted the plugins/huya/https branch July 30, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin issue A Plugin does not work correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants