stream.hls: refactor M3U8Parser state attributes #5521
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the parser state in dedicated attributes with proper typing information instead of using a state hash map with arbitrary keys.
This was never changed since the initial implementation in 39008e9, probably because of the convenience of being able to read and unset certain data in a single call via
pop()
. That however doesn't justify the CPU and memory disadvantanges that come with this design choice, so let's finally fix it.