Skip to content

plugins.goodgame: fix plugin #5597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

Mehavoid
Copy link
Contributor

@Mehavoid Mehavoid commented Oct 8, 2023

Some streamers have a different player ID than the channel ID.

streamlink -l trace goodgame.ru/channel/miker
[14:55:00.212898][session][debug] Plugin goodgame is being overridden by /home/*/.local/share/streamlink/plugins/goodgame.py
[14:55:00.231627][cli][debug] OS:         Linux-5.4.0-139-generic-x86_64-with-glibc2.31
[14:55:00.231865][cli][debug] Python:     3.9.5
[14:55:00.231977][cli][debug] OpenSSL:    OpenSSL 1.1.1f  31 Mar 2020
[14:55:00.232092][cli][debug] Streamlink: 6.2.1
[14:55:00.232995][cli][debug] Dependencies:
[14:55:00.235118][cli][debug]  certifi: 2023.7.22
[14:55:00.236184][cli][debug]  isodate: 0.6.0
[14:55:00.237114][cli][debug]  lxml: 4.7.1
[14:55:00.238251][cli][debug]  pycountry: 22.1.10
[14:55:00.239149][cli][debug]  pycryptodome: 3.9.9
[14:55:00.240104][cli][debug]  PySocks: 1.7.1
[14:55:00.241042][cli][debug]  requests: 2.31.0
[14:55:00.241936][cli][debug]  trio: 0.22.2
[14:55:00.242826][cli][debug]  trio-websocket: 0.11.1
[14:55:00.243840][cli][debug]  typing-extensions: 4.5.0
[14:55:00.244795][cli][debug]  urllib3: 2.0.6
[14:55:00.245786][cli][debug]  websocket-client: 1.2.3
[14:55:00.246126][cli][debug] Arguments:
[14:55:00.246211][cli][debug]  url=goodgame.ru/channel/miker
[14:55:00.246316][cli][debug]  --loglevel=trace
[14:55:00.246692][cli][info] Found matching plugin goodgame for URL goodgame.ru/channel/miker
[14:55:00.246791][plugins.goodgame][debug] api_url='https://goodgame.ru/api/4/streams/2/channel/miker'
[14:55:00.489954][plugins.goodgame][debug] Channel is offline, checking for embedded players...
error: No playable streams found on this URL: goodgame.ru/channel/miker

https://goodgame.ru/player?5

curl -s 'https://goodgame.ru/api/player?src=5' -H 'Cookie: PHPSESSID=425ggau6ptos93uqg9l5kgnsn9' --compressed | jq
{
  "user": []
}

https://goodgame.ru/player?6

 curl -s 'https://goodgame.ru/api/player?src=6' -H 'Cookie: PHPSESSID=425ggau6ptos93uqg9l5kgnsn9' --compressed | jq
{
  "channel_id": "5",
  "channel_key": "Miker",
  "channel_title": "Игропром на ВДНХ",
  "broadcast_title": null,
  "channel_status": "offline",
  "channel_poster": "https://goodgame.ru/files/logotypes/ch_5_d50J_orig.jpg",
  "channel_premium": true,
  "streamer_id": "1",
  "streamer_name": "Miker",
  "streamer_avatar": "https://goodgame.ru/files/avatars/av_1_mtmA.png",
  "premium_only": false,
  "adult": 0,
  "hidden": 0,
  "channel_start": "1696764751",
  "viewers": "88",
  "ga_code": "",
  "game_id": "34",
  "broadcast": [],
  "user": []
}

https://goodgame.ru/api/4/streams/2/channel/miker

{
    "id": 5,
    "key": "Miker",
    "preview": "https://goodgame.ru/files/logotypes/ch_5_d50J.jpg",
    "title": "Игропром на ВДНХ",
    "viewers": 111,
    "streamer": {
        "id": 1,
        "obj_key": "9:1",
        "nickname": "Miker",
        "username": "Miker",
        "avatar": "https://goodgame.ru//files/avatars/av_1_mtmA.png",
        "premium": true,
        "banned": false
    },
    "streamKey": "6",
    "online": false,
    "game": {
        "id": 34,
        "title": "Другое",
        "url": "/games/others"
    },
    "poster": "https://goodgame.ru/files/logotypes/ch_5_d50J_logo.jpg",
    "hidden": false,
    "adult": false,
    "link": "https://goodgame.ru/channel/Miker/",
    "premium": true,
    "players": [
        {
            "title": "GoodGame Премиум",
            "status": false,
            "gg": true,
            "online": false,
            "content": "<iframe frameborder=\"0\" width=\"100%\" height=\"100%\" src=\"https://goodgame.ru/player?6\"></iframe>"
        }
    ],
    "watchTogether": false,
    "lastseen": 1696768269,
    "premiums": 605,
    "followers": 24542,
    "rating": {
        "value": 0,
        "place": 0
    }
}

Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@bastimeyer bastimeyer merged commit 121b998 into streamlink:master Oct 8, 2023
@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Oct 8, 2023
@Mehavoid Mehavoid deleted the fix-goodgame-plugin branch October 8, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin issue A Plugin does not work correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants