Skip to content

stream.hls: fix segment maps #5689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bastimeyer
Copy link
Member

Only write segment maps to the output once


Fixes: #4310

Only write segment maps to the output once
@bastimeyer bastimeyer merged commit adbb942 into streamlink:master Nov 26, 2023
@bastimeyer bastimeyer deleted the stream/hls/fix-segment-maps branch November 26, 2023 23:12
This was referenced Nov 26, 2023
@bastimeyer
Copy link
Member Author

Copying this from my post of the 6.4.2 release pull request:


Old recordings with the faulty output which FFmpeg 6.1 now rejects need to be remuxed using an older FFmpeg version.

#!/usr/bin/env bash
for file in $(find . -type f -name "*.mp4" -print); do
  ffprobe -v quiet "${file}" && continue  # ffprobe >=6.1 returns status code >0 for those faulty mp4 containers
  echo "Remuxing ${file}"
  /path/to/older/ffmpeg -v error -i "${file}" -c copy -f mp4 "${file}.new" \
    && touch -c -r "${file}" "${file}.new" \
    && rm "${file}" \
    && mv "${file}.new" "${file}"
done

Where you can get an older FFmpeg build depends on your OS, but here are some relevant links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stream.hls: about the output of media initialization section
1 participant