plugins.twitch: remove is-live API check #5708
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5707
Let's remove the is-live API check again (added in #5704), for the sake of being able to start streams just after they've gone live. Twitch's GQL API has delayed data (up to a minute or so), so having this check implemented isn't ideal. It does prevent the empty metadata issue though, but I don't think it's important.
The second commit which is included here removes an unnecessary error message for offline channels, but only in those cases where no JSON data was returned by the multivariant playlist error response. I will have a look later at checking the API for offline channels after the playlist has returned 4xx. No idea about geo-blocked content yet though, which was the reason for parsing the JSON data.
Online channel (listing streams now takes a bit longer due to
check_streams=True
)Offline channel with bad data on Twitch's end is now actually offline (due to
check_streams=True
)Offline channel with JSON data in HLS multivariant playlist response (still garbage error log message)
Offline channel without JSON data in HLS multivariant playlist response (no more unnecessary error log message)