plugins.rtbf: remove plugin #5801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
force-pushed
the
plugins/rtbf/fix-matcher-regex
branch
from
bdebab0 to
5074904
Compare
bastimeyer
force-pushed
the
plugins/rtbf/fix-matcher-regex
branch
from
5074904 to
c8a7955
Compare
bastimeyer
added
plugin removal
and removed
plugin issue
bastimeyer
changed the title
|
Rebased... Going to remove the plugin instead... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin's matcher pattern needs to be fixed, because it's defining a verbose pattern while not escaping the
#character (which is interpreted as a comment), so it breaks the pattern's non-capture group when minifying the pattern in the plugins JSON build script (#5793) where it removes line breaks and leading whitespace of each line. The verbose-pattern issue was introduced by me in 98428d6 three years ago.As far as I can tell though, the plugin is completely broken and doesn't even match the URLs the site uses now. The last time it was updated was 6 years ago:
https://github.com/streamlink/streamlink/commits/6.5.1/src/streamlink/plugins/rtbf.py
The site now also requires a login when accessing it, but I'm not sure if that's only the case when accessing it from outside of France/Belgium. It's also required when using proxies/VPNs. The DASH streams are working fine though without a proxy when copying the URL from the web browser's dev tools.
If it's broken, then it should be removed instead. Can someone clarify?
Pinging @melmorabity, who's added the plugin and who's updated it last.