Skip to content

plugins.mangomolo: new plugin #5852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2024
Merged

plugins.mangomolo: new plugin #5852

merged 1 commit into from
Feb 25, 2024

Conversation

bastimeyer
Copy link
Member

Resolves #5850
Rel #5848

$ ./script/test-plugin-urls.py mangomolo
:: Finding streams for URL: https://media.gov.kw/LiveTV.aspx?PanChannel=KTV1
:: Found streams: 240p, 360p, 720p, 1080p, worst, best
:: Finding streams for URL: https://media.gov.kw/LiveTV.aspx?PanChannel=KTVSports
:: Found streams: 240p, 360p, 720p, 1080p, worst, best
:: Finding streams for URL: https://player.mangomolo.com/v1/live?id=MTk1&channelid=MzU1&countries=bnVsbA==&w=100%25&h=100%25&autoplay=true&filter=none&signature=9ea6c8ed03b8de6e339d6df2b0685f25&app_id=43
:: Found streams: 240p, 360p, 720p, 1080p, worst, best

I wish there were a better way for platforms like this where other companies/organizations embed their player into their site. Adding plugin matchers with a low priority that matches everything is surely not the right idea, so embedding sites need to be added explicitly. Maybe it's worth figuring out a solution. That would allow sites which embed YouTube or Vimeo player or what not to be matched. Maybe an embed:// plugin which tries to find embedded players by making another plugin lookup on the session instance.

@ipstreet312
Copy link

Hello, I tested fyi I get following blocked error :

streams = session.streams('https://media.gov.kw/LiveTV.aspx?PanChannel=KTV1')
File "/opt/hostedtoolcache/Python/3.12.2/x64/lib/python3.12/site-packages/streamlink/session/http.py", line 190, in request
    raise err from None  # TODO: fix this
    ^^^^^^^^^^^^^^^^^^^
streamlink.exceptions.PluginError: Unable to open URL: https://media.gov.kw/LiveTV.aspx?PanChannel=KTV1 (403 Client Error: Forbidden for url: https://media.gov.kw/LiveTV.aspx?PanChannel=KTV1)
Error: Process completed with exit code 1.

@bastimeyer
Copy link
Member Author

403 Client Error: Forbidden for url: https://media.gov.kw/LiveTV.aspx?PanChannel=KTV1

Not a plugin issue. You've been blocked from media.gov.kw which isn't even where the stream is hosted, just where the mangomolo player is embedded.

@bastimeyer bastimeyer merged commit 398610c into streamlink:master Feb 25, 2024
@bastimeyer bastimeyer deleted the plugins/mangomolo/init branch February 25, 2024 08:28
@andaluspc
Copy link

Hello @bastimeyer. I couldn't find what's the next step about Kuwait channels now? I wanted to raise an issue but found two issues talk about the same topic but both are closed.
Will there be a fix for this?
I remember that Kuwait channels were previously using "aloula" plugin!, now they are using "mangomolo" plugin.

@bastimeyer
Copy link
Member Author

Please don't comment on closed pull requests. If there's an issue with a plugin on the master branch or in the latest stable release, then open a new plugin issue.

Plugin issues get closed for a reason, e.g. because necessary code changes were merged via a pull request. If they were closed for any other reason, then this is stated via a comment. You make it sound like no information was given at all why those previous issues were closed. That is not true. Also please look at the date when those issues were closed...

In regards to this plugin here, I just checked again and the streams apparently don't get resolved correctly because a Referer header is missing on the player iframe. Fixing this is trivial.

Going to lock this PR now and submit a quick fix. If you had opened an issue instead of posting here, then this plugin issue wouldn't be buried in a locked PR and could be properly referenced and closed when merging the bugfix pull request.

@streamlink streamlink locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
new plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

media.gov.kw / mangomolo.com plugin request
3 participants
@bastimeyer @ipstreet312 @andaluspc