plugins.ltv_lsm_lv: fix plugin, rm LTVHLSStream #5858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
added
plugin issue
- Fix embedded player iframe validation schema - Update pluginmatcher - Remove unneeded HLSStream subclass
bastimeyer
force-pushed
the
plugins/ltvlsmlv/fix-iframe-and-hls-stream
branch
from
6f09f94 to
1483e44
Compare
|
Force-pushed with an update of the plugin matcher (replay support), and also removed the custom HLSStream subclass. As said, live streams are geo-blocked for me and show a warning message stream instead, so it's possible that the actual live streams still require the custom HLSStream implementation. |
|
Thanks for the super quick fix. This did indeed solve the issue. Log (using proxy for geo block): |
bastimeyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5857
Two issues:
HLSStreamWorkersubclass was not updated after some changes were made in the base class, resulting in an incompatible signature ofLTVHLSStreamWorker.process_segments()(probably the reason why @karlis-vagalis was using the--stream-urlparameter)@karlis-vagalis please check and verify these plugin fixes using a couple of different stream URLs, as the live content is geo-blocked for me and it's only listing replays/VODs on their site. Please include a short debug log (without
--stream-url), thanks.https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback
I also have no idea if the custom HLSStream implementation is even necessary anymore. The streams apparently are working fine without it, but I can't say that this is the case for every stream on their site.
--stream-urlcompletely bypasses Streamlink's HLS implementation, including the plugin's custom subclass of course, so if the streams have been working previously using that CLI parameter, then that would suggest that the custom HLS implementation with the playlist+segment URL query string overrides is indeed unnecessary.