Skip to content

tests: require pytest 8.0.0 #5901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

bastimeyer
Copy link
Member

Apparently, pytest's ExceptionInfo.group_contains() was only just added in pytest 8.0.0:
https://docs.pytest.org/en/8.0.x/changelog.html#additional-support-for-exception-groups-and-notes

I wasn't aware of this, because it's not noted in their docs directly like most stuff. That utility function is required by the updated tests in #5895 when making assertions about ExceptionGroups.

Streamlink's dev-requirements should therefore bump the min-requirement of pytest to 8.0.0.

@bastimeyer bastimeyer merged commit 7c7c98f into streamlink:master Mar 19, 2024
@bastimeyer bastimeyer deleted the tests/pytest-8.0.0 branch March 19, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant