Skip to content

cli: fix passthrough without player #6207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bastimeyer
Copy link
Member

Fixes #6206

$ env PATH="" ~/venv/streamlink-312/bin/python -m streamlink --no-config -l debug --player-passthrough=hls twitch.tv/esl_dota2 best
NotVCSError: Git not installed; assuming this isn't a Git repository
[cli][debug] OS:         Linux-6.11.0-1-git-x86_64-with-glibc2.40
[cli][debug] Python:     3.12.6
[cli][debug] OpenSSL:    OpenSSL 3.3.2 3 Sep 2024
[cli][debug] Streamlink: 0.0.0+unknown
[cli][debug] Dependencies:
[cli][debug]  certifi: 2024.8.30
[cli][debug]  isodate: 0.6.1
[cli][debug]  lxml: 5.3.0
[cli][debug]  pycountry: 24.6.1
[cli][debug]  pycryptodome: 3.20.0
[cli][debug]  PySocks: 1.7.1
[cli][debug]  requests: 2.32.3
[cli][debug]  trio: 0.26.2
[cli][debug]  trio-websocket: 0.12.0.dev0
[cli][debug]  typing-extensions: 4.12.2
[cli][debug]  urllib3: 2.2.3
[cli][debug]  websocket-client: 1.8.0
[cli][debug] Arguments:
[cli][debug]  url=twitch.tv/esl_dota2
[cli][debug]  stream=['best']
[cli][debug]  --no-config=True
[cli][debug]  --loglevel=debug
[cli][debug]  --player-passthrough=['hls']
[cli][info] Found matching plugin twitch for URL twitch.tv/esl_dota2
[plugins.twitch][debug] Getting live HLS streams for esl_dota2
[plugins.twitch][debug] {'adblock': False, 'geoblock_reason': '', 'hide_ads': False, 'server_ads': True, 'show_ads': True}
[utils.l10n][debug] Language code: en_US
[cli][info] Available streams: audio_only, 160p (worst), 360p, 480p, 720p60, 1080p60 (best)
[cli][info] Opening stream: 1080p60 (hls)
error: The default player (VLC) does not seem to be installed. You must specify the path to a player executable with --player.

@bastimeyer bastimeyer merged commit 1e074ba into streamlink:master Sep 28, 2024
25 checks passed
@bastimeyer bastimeyer deleted the cli/fix-passthrough-without-player branch September 28, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: --player="" --player-passthrough=hls causes AttributeError: 'NoneType' object has no attribute 'name'
1 participant