Skip to content

cli: warn when deprecated plugin argument is set #6240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2024
Merged

cli: warn when deprecated plugin argument is set #6240

merged 2 commits into from
Oct 12, 2024

Conversation

bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Oct 11, 2024 •
edited
Loading 

$ streamlink twitch.tv/CHANNEL
[cli][info] Found matching plugin twitch for URL twitch.tv/CHANNEL
error: No playable streams found on this URL: twitch.tv/CHANNEL

$ streamlink twitch.tv/CHANNEL --twitch-disable-hosting --twitch-disable-reruns
[warnings][streamlinkdeprecation] The --twitch-disable-hosting plugin argument has been disabled and will be removed in the future
[warnings][streamlinkdeprecation] The --twitch-disable-reruns plugin argument has been disabled and will be removed in the future
[cli][info] Found matching plugin twitch for URL twitch.tv/CHANNEL
error: No playable streams found on this URL: twitch.tv/CHANNEL

$ echo -e 'twitch-disable-hosting\ntwitch-disable-reruns' > /tmp/config
$ streamlink --config /tmp/config twitch.tv/CHANNEL
[warnings][streamlinkdeprecation] The --twitch-disable-hosting plugin argument has been disabled and will be removed in the future
[warnings][streamlinkdeprecation] The --twitch-disable-reruns plugin argument has been disabled and will be removed in the future
[cli][info] Found matching plugin twitch for URL twitch.tv/CHANNEL
error: No playable streams found on this URL: twitch.tv/CHANNEL

@bastimeyer bastimeyer added the CLI label Oct 11, 2024
@bastimeyer bastimeyer marked this pull request as draft October 11, 2024 22:50
@bastimeyer bastimeyer force-pushed the cli/warn-on-deprecated-plugin-arg branch from 7a4bf7a to 4aa2ef5 Compare October 12, 2024 17:31
@bastimeyer bastimeyer marked this pull request as ready for review October 12, 2024 17:38
@bastimeyer bastimeyer merged commit 37c9e10 into streamlink:master Oct 12, 2024
23 checks passed
@bastimeyer bastimeyer deleted the cli/warn-on-deprecated-plugin-arg branch October 12, 2024 17:38
@bastimeyer bastimeyer mentioned this pull request Oct 12, 2024
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bastimeyer