Skip to content

cli.argparser: rewrite and fix help texts #6255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bastimeyer
Copy link
Member

  • Remove unnecessary line breaks and adjust line length in preparation for indentation changes
  • Fix minor spelling, grammar and punctuation errors, as well as names
  • Rephrase and always use imperative or a descriptive style without talking to the reader or in third person
  • Use common style when enumerating possible values
  • Reference other related arguments where it makes sense
  • Explicitly mention stdout/stderr instead of console output
  • Rewrite incorrect/inaccurate and outdated help texts

- Remove unnecessary line breaks and adjust line length in preparation
  for indentation changes
- Fix minor spelling, grammar and punctuation errors, as well as names
- Rephrase and always use imperative or a descriptive style without
  talking to the reader or in third person
- Use common style when enumerating possible values
- Reference other related arguments where it makes sense
- Explicitly mention stdout/stderr instead of console output
- Rewrite incorrect/inaccurate and outdated help texts
@bastimeyer bastimeyer force-pushed the cli/argparse/update-help-texts branch from 378433b to 1844afc Compare October 19, 2024 00:55
@bastimeyer bastimeyer requested a review from gravyboat October 19, 2024 00:56
@bastimeyer
Copy link
Member Author

bastimeyer commented Oct 19, 2024

Please have a quick look when you have the time for any obvious mistakes or potentially confusing stuff, @gravyboat. Also the unchanged help texts. See the rendered docs.

https://streamlink--6255.org.readthedocs.build/cli.html

@bastimeyer
Copy link
Member Author

If nobody's had a look at this until the end of tomorrow, I'm going to merge regardless. I don't think there's anything wrong here, and if there are any potential improvements (which I'm sure there always are), then those can be made later on. The current changes are already an improvement.

The reason I don't want to wait is that I have formatting changes queued up (ruff format) with mandatory ruff format --diff checks for the CI linting workflow, and this PR blocks those changes. I want 7.0.0 with a strict code style format, which we've been avoiding the whole time until now (both black and ruff).

Copy link
Member

@mkbloke mkbloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything you've changed looks fine to me.

@bastimeyer bastimeyer merged commit 269b2a6 into streamlink:master Oct 20, 2024
23 checks passed
@bastimeyer bastimeyer deleted the cli/argparse/update-help-texts branch October 20, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants