Skip to content

plugins.dailymotion: add lequipe.fr #6372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

BZHDeveloper1986
Copy link
Contributor

Modification of the plugin to add live streams from “l'équipe” channel

Add support for sites embedding the dailymotion player

Co-Authored-By: bastimeyer <mail@bastimeyer.de>
@bastimeyer bastimeyer added the plugin enhancement A new feature for a working Plugin label Dec 30, 2024
@bastimeyer
Copy link
Member

Thanks for the PR.

I made some modifications to the PR, since there were a couple of issues. Fixing and improving them myself was quicker than reviewing and annotating the changes. The PR branch of your fork (which unfortunately is master) has been updated and force-pushed.

  • I fixed the commit message and commit authorship (the previous commit author was using a different GH account), and I added myself to the co-authors
  • I removed the unnecessary urllib import and simply set the embedder query string parameter via requests' params request parameter
  • The lequipe matcher has been changed, so that other kinds of videos are supported on the site, like VODs for example
  • And most importantly, the updated changes allow for easier addition for other sites which embed the dailymotion player. The video ID is now extracted from the HTML response, rather than the input URL.
$ HTTPS_PROXY=socks5h://localhost:1920 ./script/test-plugin-urls.py dailymotion
:: https://www.dailymotion.com/embed/video/x8dmdzz
::  288p, 480p, 720p, 1080p, worst, best
:: https://www.dailymotion.com/france24
:::: No live streams found for channel france24
!! No streams found
:: https://www.dailymotion.com/video/x8dmdzz
::  288p, 480p, 720p, 1080p, worst, best
:: https://www.lequipe.fr/tv/replay/le-resume-de-la-mass-start-du-grand-bornand/20201780
::  288p, 480p, 720p, 1080p, worst, best
:: https://www.lequipe.fr/tv/videos/live/k3HiS3JB0BsORKqwC49
::  180p, 288p, 477p, 720p, 1080p, worst, best

@BZHDeveloper1986
Copy link
Contributor Author

thanks for the review

@bastimeyer bastimeyer changed the title plugins.dailymotion : add L'Équipe streams plugins.dailymotion: add lequipe.fr Dec 30, 2024
@bastimeyer bastimeyer merged commit b9ffd8d into streamlink:master Dec 30, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin enhancement A new feature for a working Plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants