Skip to content

plugins.bbciplayer: fix/update state_re regex #3725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2021
Merged

plugins.bbciplayer: fix/update state_re regex #3725

merged 1 commit into from
May 14, 2021

Conversation

mkbloke
Copy link
Member

@mkbloke mkbloke commented May 14, 2021 •
edited
Loading

This started happening yesterday:

error: Unable to parse JSON: Extra data: line 1 column 32793 (char 32792) ('{"navigation":{"items":[{"id":"cha ...)

The old greedy regex was also grabbing:

;</script><script id="tvip-script-app-client-config">window.__IPLAYER_CLIENT_CONFIG__ = {"logger":{"level":"error","telemetryUrl":"https://monitoring.ede565d7c6c3ee6b.xhst.bbci.co.uk/tvr-telemetry/iplayer-web/telemetry","serviceName":"iplayer-web-app-highlights","telemetrySamplingRate":0}}

This fixes it. Tested on various live channels and VODs.

closes #3726

@mkbloke mkbloke mentioned this pull request May 14, 2021
Closed
@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label May 14, 2021
@bastimeyer bastimeyer merged commit ab033b3 into streamlink:master May 14, 2021
@bastimeyer
Copy link
Member

Thanks, @mkbloke

@mkbloke mkbloke deleted the bbciplayer branch May 14, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
plugin issue A Plugin does not work correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugins.bbciplayer: Not working
2 participants
@mkbloke @bastimeyer