Skip to content

Route Refresh restarts peer #1237

@djb610

Description

@djb610

** Bug Report **
Similar issue to #708

When route-refresh is requested the BGP Peer restarts.

Tue, 24 Sep 2024 10:42:22 18     outgoing-1    peer reset, message [] error[]
Tue, 24 Sep 2024 10:42:22 18     outgoing-1    outgoing-1 172.16.20.36-172.16.24.20, closing connection
Tue, 24 Sep 2024 10:42:22 18     reactor       initialising connection to peer-1
Tue, 24 Sep 2024 10:42:22 18     outgoing-5    attempting connection to 172.16.24.20:179
<< message of type ROUTE_REFRESH
Tue, 24 Sep 2024 10:42:22 18     reactor       
Tue, 24 Sep 2024 10:42:22 18     reactor       ********************************************************************************
Tue, 24 Sep 2024 10:42:22 18     reactor       EXABGP MISBEHAVED / HELP US FIX IT
Tue, 24 Sep 2024 10:42:22 18     reactor       ********************************************************************************
Tue, 24 Sep 2024 10:42:22 18     reactor       
Tue, 24 Sep 2024 10:42:22 18     reactor       Sorry, you encountered a problem with ExaBGP, as the problem only affects one
Tue, 24 Sep 2024 10:42:22 18     reactor       peer, we are trying to keep the program running.
Tue, 24 Sep 2024 10:42:22 18     reactor       
Tue, 24 Sep 2024 10:42:22 18     reactor       There are a few things you can do to help us (and yourself):
Tue, 24 Sep 2024 10:42:22 18     reactor       - make sure you are running the latest version of the code available at
Tue, 24 Sep 2024 10:42:22 18     reactor         https://github.com/Exa-Networks/exabgp/releases/latest
Tue, 24 Sep 2024 10:42:22 18     reactor       - if so report the issue on https://github.com/Exa-Networks/exabgp/issues
Tue, 24 Sep 2024 10:42:22 18     reactor         so it can be fixed (github can be searched for similar reports)
Tue, 24 Sep 2024 10:42:22 18     reactor       
Tue, 24 Sep 2024 10:42:22 18     reactor       PLEASE, when reporting, do include as much information as you can:
Tue, 24 Sep 2024 10:42:22 18     reactor       - do not obfuscate any data (feel free to send us a private  email with the
Tue, 24 Sep 2024 10:42:22 18     reactor         extra information if your business policy is strict on information sharing)
Tue, 24 Sep 2024 10:42:22 18     reactor         https://github.com/Exa-Networks/exabgp/wiki/FAQ
Tue, 24 Sep 2024 10:42:22 18     reactor       - if you can reproduce the issue, run ExaBGP with the command line option -d
Tue, 24 Sep 2024 10:42:22 18     reactor         it provides us with much needed information to fix problems quickly
Tue, 24 Sep 2024 10:42:22 18     reactor       - include the information presented below
Tue, 24 Sep 2024 10:42:22 18     reactor       
Tue, 24 Sep 2024 10:42:22 18     reactor       Should you not receive an acknowledgment of your issue on github (assignement,
Tue, 24 Sep 2024 10:42:22 18     reactor       comment, or similar) within a few hours, feel free to email us to make sure
Tue, 24 Sep 2024 10:42:22 18     reactor       it was not overlooked. (please keep in mind the authors are based in GMT/Europe)
Tue, 24 Sep 2024 10:42:22 18     reactor       
Tue, 24 Sep 2024 10:42:22 18     reactor       ********************************************************************************
Tue, 24 Sep 2024 10:42:22 18     reactor       -- Please provide ALL the information below on :
Tue, 24 Sep 2024 10:42:22 18     reactor       -- https://github.com/Exa-Networks/exabgp/issues
Tue, 24 Sep 2024 10:42:22 18     reactor       ********************************************************************************
Tue, 24 Sep 2024 10:42:22 18     reactor       
Tue, 24 Sep 2024 10:42:22 18     reactor       ExaBGP version : 4.2.22
Tue, 24 Sep 2024 10:42:22 18     reactor       Python version : 3.8.10 (default, May  6 2021, 06:30:44)  [GCC 9.3.0]
Tue, 24 Sep 2024 10:42:22 18     reactor       System Uname   : #1 SMP Tue Oct 12 11:32:07 PDT 2021
Tue, 24 Sep 2024 10:42:22 18     reactor       System MaxInt  : 9223372036854775807
Tue, 24 Sep 2024 10:42:22 18     reactor       
Tue, 24 Sep 2024 10:42:22 18     reactor       
Tue, 24 Sep 2024 10:42:22 18     reactor       
Tue, 24 Sep 2024 10:42:22 18     reactor       
Tue, 24 Sep 2024 10:42:22 18     reactor       <class 'TypeError'>
Tue, 24 Sep 2024 10:42:22 18     reactor       'RouteRefresh' object is not iterable
Tue, 24 Sep 2024 10:42:22 18     reactor       Traceback (most recent call last):
Tue, 24 Sep 2024 10:42:22 18     reactor         File "/usr/lib/python3.8/site-packages/exabgp/reactor/peer.py", line 554, in _run
Tue, 24 Sep 2024 10:42:22 18     reactor           for action in self._main():
Tue, 24 Sep 2024 10:42:22 18     reactor         File "/usr/lib/python3.8/site-packages/exabgp/reactor/peer.py", line 502, in _main
Tue, 24 Sep 2024 10:42:22 18     reactor           six.next(new_routes)
Tue, 24 Sep 2024 10:42:22 18     reactor         File "/usr/lib/python3.8/site-packages/exabgp/reactor/protocol.py", line 372, in new_update
Tue, 24 Sep 2024 10:42:22 18     reactor           for message in update.messages(self.negotiated, include_withdraw):
Tue, 24 Sep 2024 10:42:22 18     reactor         File "/usr/lib/python3.8/site-packages/exabgp/bgp/message/update/__init__.py", line 116, in messages
Tue, 24 Sep 2024 10:42:22 18     reactor           for nlri in sorted(self.nlris):
Tue, 24 Sep 2024 10:42:22 18     reactor       TypeError: 'RouteRefresh' object is not iterable
Tue, 24 Sep 2024 10:42:22 18     reactor       
Tue, 24 Sep 2024 10:42:22 18     reactor       ********************************************************************************
Tue, 24 Sep 2024 10:42:22 18     reactor       -- Please provide _ALL_ the information above on :
Tue, 24 Sep 2024 10:42:22 18     reactor       -- https://github.com/Exa-Networks/exabgp/issues
Tue, 24 Sep 2024 10:42:22 18     reactor       ********************************************************************************
Tue, 24 Sep 2024 10:42:22 18     reactor       
Tue, 24 Sep 2024 10:42:22 18     outgoing-1    peer reset, message [] error[]
Tue, 24 Sep 2024 10:42:22 18     outgoing-1    outgoing-1 172.16.20.36-172.16.24.20, closing connection
Tue, 24 Sep 2024 10:42:22 18     reactor       initialising connection to peer-1
Tue, 24 Sep 2024 10:42:22 18     outgoing-5    attempting connection to 172.16.24.20:179

To Reproduce

database is cleared/flushed manually request to route -refresh with exabgp-cli.

announce route-refresh ipv4 unicast

Expected behavior

No BGP restart with route refresh

ExaBGP version : 4.2.22
Python version : 3.8.10

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions