Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tinkerbell/charts
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.6.1
Choose a base ref
...
head repository: tinkerbell/charts
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.6.2
Choose a head ref
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Dec 6, 2024

  1. Use env vars in Smee instead of CLI flags:

    This allows an unset value for an env var to invoke
    Smee's automatic IP detection to trigger. With CLI
    flags this automatic IP detection doesnt work.
    
    Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
    jacobweinstock committed Dec 6, 2024
    Configuration menu
    Copy the full SHA
    68c36dd View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2024

  1. Merge pull request #150 from jacobweinstock/smee-flags-to-envs

    Use env vars in Smee instead of CLI flags:
    
    ## Description
    
    <!--- Please describe what this PR is going to change -->
    This allows an unset value for an env variable to invoke Smee's automatic IP detection to trigger. With CLI flags this automatic IP detection doesnt work.
    
    ## Why is this needed
    
    <!--- Link to issue you have raised -->
    
    Fixes: #
    
    ## How Has This Been Tested?
    <!--- Please describe in detail how you tested your changes. -->
    <!--- Include details of your testing environment, and the tests you ran to -->
    <!--- see how your change affects other areas of the code, etc. -->
    
    
    ## How are existing users impacted? What migration steps/scripts do we need?
    
    <!--- Fixes a bug, unblocks installation, removes a component of the stack etc -->
    <!--- Requires a DB migration script, etc. -->
    
    
    ## Checklist:
    
    I have:
    
    - [ ] updated the documentation and/or roadmap (if required)
    - [ ] added unit or e2e tests
    - [ ] provided instructions on how to upgrade
    jacobweinstock authored Dec 9, 2024
    Configuration menu
    Copy the full SHA
    fdf070f View commit details
    Browse the repository at this point in the history
Loading