Skip to content

[OTAGENT-426] Add zlib/zstd build tags to otel-agent and use zstd compression for logs #37897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[OTAGENT-426] Add zlib/zstd build tags to otel-agent and use zstd compression for logs #37897

wants to merge 6 commits into from
+12 −3

Conversation

liustanley
Copy link
Contributor

@liustanley liustanley commented Jun 12, 2025 •
edited
Loading

What does this PR do?

Adds zlib and zstd build tags to otel-agent and uses zstd compression for logs.

Motivation

Follow up to #37901. We want to use zstd compression in the DDOT logs agent now that it is the default.

Describe how you validated your changes

Built otel-agent locally and verified zstd is being used:

2025-06-12 11:12:41 EDT | OTELCOL | DEBUG | (comp/logs/agent/config/config_keys.go:145 in compressionLevel) | Logs pipeline is using compression zstd at level: 1

Possible Drawbacks / Trade-offs

Additional Notes

@liustanley liustanley added this to the 7.68.0 milestone Jun 12, 2025
@liustanley liustanley requested a review from a team as a code owner June 12, 2025 15:22
@liustanley liustanley added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/opentelemetry-agent backport/7.67.x Automatically create a backport PR to 7.67.x labels Jun 12, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jun 12, 2025
@liustanley liustanley removed the backport/7.67.x Automatically create a backport PR to 7.67.x label Jun 12, 2025
@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jun 12, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 15b09e2c-e16e-4081-9df3-265c4904deb2

Baseline: cca3fa1
Comparison: 158fb62
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +4.32 [+1.24, +7.40] 1 Logs
➖ quality_gate_logs % cpu utilization +3.71 [+0.87, +6.54] 1 Logs bounds checks dashboard
➖ quality_gate_idle memory utilization +0.87 [+0.81, +0.92] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization +0.70 [+0.62, +0.78] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.65 [+0.60, +0.70] 1 Logs
➖ ddot_metrics memory utilization +0.33 [+0.21, +0.44] 1 Logs
➖ otlp_ingest_logs memory utilization +0.19 [+0.06, +0.32] 1 Logs
➖ ddot_logs memory utilization +0.15 [+0.04, +0.26] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.11 [-0.49, +0.71] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.07 [-0.09, +0.24] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.06 [-0.49, +0.62] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.05 [-0.53, +0.62] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.03, +0.02] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.29, +0.27] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.02 [-0.61, +0.57] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.03 [-0.66, +0.59] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.04 [-0.63, +0.56] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.05 [-0.67, +0.57] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.11 [-0.34, +0.13] 1 Logs
➖ docker_containers_memory memory utilization -0.40 [-0.46, -0.34] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.46 [-0.55, -0.38] 1 Logs
➖ file_tree memory utilization -0.86 [-1.02, -0.70] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -2.37 [-3.27, -1.48] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 12, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor cca3fa1

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${0}$$ $${697.02}$$ < $${697.37}$$ $${+0}$$ $${176.1}$$ < $${177.03}$$
✅ agent_deb_amd64_fips $${0}$$ $${695.3}$$ < $${695.59}$$ $${-0.05}$$ $${175.52}$$ < $${176.51}$$
✅ agent_heroku_amd64 $${0}$$ $${358.67}$$ < $${359.67}$$ $${+0.01}$$ $${96.52}$$ < $${97.47}$$
✅ agent_msi $${0}$$ $${958.88}$$ < $${959.86}$$ $${-0}$$ $${146.3}$$ < $${147.27}$$
✅ agent_rpm_amd64 $${0}$$ $${697.0}$$ < $${697.36}$$ $${-0.03}$$ $${177.68}$$ < $${178.56}$$
✅ agent_rpm_amd64_fips $${0}$$ $${695.29}$$ < $${695.58}$$ $${-0}$$ $${177.57}$$ < $${178.43}$$
✅ agent_rpm_arm64 $${0}$$ $${687.03}$$ < $${687.37}$$ $${+0.04}$$ $${161.11}$$ < $${161.99}$$
✅ agent_rpm_arm64_fips $${0}$$ $${685.43}$$ < $${685.72}$$ $${+0.02}$$ $${160.28}$$ < $${161.11}$$
✅ agent_suse_amd64 $${0}$$ $${697.0}$$ < $${697.36}$$ $${-0.03}$$ $${177.68}$$ < $${178.56}$$
✅ agent_suse_amd64_fips $${0}$$ $${695.29}$$ < $${695.58}$$ $${-0}$$ $${177.57}$$ < $${178.43}$$
✅ agent_suse_arm64 $${0}$$ $${687.03}$$ < $${687.37}$$ $${+0.04}$$ $${161.11}$$ < $${161.99}$$
✅ agent_suse_arm64_fips $${0}$$ $${685.43}$$ < $${685.72}$$ $${+0.02}$$ $${160.28}$$ < $${161.11}$$
✅ docker_agent_amd64 $${-0}$$ $${780.8}$$ < $${781.16}$$ $${-0}$$ $${268.79}$$ < $${269.63}$$
✅ docker_agent_arm64 $${+0}$$ $${794.28}$$ < $${794.62}$$ $${-0}$$ $${256.14}$$ < $${257.0}$$
✅ docker_agent_jmx_amd64 $${+0}$$ $${972.0}$$ < $${972.35}$$ $${+0}$$ $${337.76}$$ < $${338.6}$$
✅ docker_agent_jmx_arm64 $${+0}$$ $${974.07}$$ < $${974.41}$$ $${+0}$$ $${321.07}$$ < $${321.97}$$
✅ docker_agent_windows1809 $${-0.02}$$ $${1486.95}$$ < $${1488.0}$$ $${+0.06}$$ $${488.02}$$ < $${488.95}$$
✅ docker_agent_windows1809_core $${+0}$$ $${6216.98}$$ < $${6218.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_core_jmx $${-0.13}$$ $${6338.55}$$ < $${6361.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_jmx $${+0}$$ $${1608.65}$$ < $${1609.5}$$ $${+0.03}$$ $${530.34}$$ < $${531.32}$$
✅ docker_agent_windows2022 $${-0.07}$$ $${1506.25}$$ < $${1507.0}$$ $${+0}$$ $${500.76}$$ < $${501.7}$$
✅ docker_agent_windows2022_core $${-0.19}$$ $${6190.1}$$ < $${6311.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows2022_core_jmx $${+0.13}$$ $${6311.81}$$ < $${6313.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows2022_jmx $${-0.22}$$ $${1627.91}$$ < $${1628.16}$$ $${-0.08}$$ $${543.03}$$ < $${543.98}$$
✅ docker_cluster_agent_amd64 $${-0}$$ $${212.84}$$ < $${213.79}$$ $${-0}$$ $${72.38}$$ < $${73.33}$$
✅ docker_cluster_agent_arm64 $${0}$$ $${228.68}$$ < $${229.64}$$ $${-0}$$ $${68.65}$$ < $${69.6}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${+0}$$ $${39.22}$$ < $${39.57}$$ $${+0}$$ $${15.12}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${-0}$$ $${37.88}$$ < $${38.2}$$ $${-0}$$ $${14.53}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${-0}$$ $${8.0}$$ < $${8.95}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.02}$$ < $${29.97}$$ $${-0}$$ $${6.94}$$ < $${7.89}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0}$$ $${8.01}$$ < $${8.96}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0}$$ $${8.01}$$ < $${8.96}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${-0}$$ $${12.84}$$ < $${13.79}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${-0}$$ $${11.13}$$ < $${12.09}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.47}$$ < $${48.42}$$ $${-0.01}$$ $${11.19}$$ < $${12.16}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${-0}$$ $${12.86}$$ < $${13.81}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${-0}$$ $${11.15}$$ < $${12.11}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${-0}$$ $${12.86}$$ < $${13.81}$$

@liustanley liustanley requested a review from a team as a code owner June 13, 2025 15:29
@liustanley liustanley changed the title [OTAGENT-426] Add zlib and zstd build tags to otel-agent [OTAGENT-426] Add zlib/zstd build tags to otel-agent and use zstd compression for logs Jun 13, 2025
@liustanley liustanley modified the milestones: 7.68.0, 7.69.0 Jun 16, 2025
@liustanley liustanley requested a review from a team as a code owner June 16, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@urseberry urseberry urseberry approved these changes

@CelianR CelianR CelianR approved these changes

@tim-liakh-datadog tim-liakh-datadog Awaiting requested review from tim-liakh-datadog tim-liakh-datadog is a code owner automatically assigned from DataDog/opentelemetry-agent

Assignees
No one assigned
Labels
qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/opentelemetry-agent
Projects
None yet
Milestone
7.69.0
Development

Successfully merging this pull request may close these issues.
4 participants
@liustanley @songy23 @urseberry @CelianR