Skip to content

fixed broken DOMActivate example #39846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 26, 2025
Merged

fixed broken DOMActivate example #39846

merged 6 commits into from
Jul 26, 2025

Conversation

addsoupbase
Copy link
Contributor

@addsoupbase addsoupbase commented Jun 7, 2025

Fixed broken, overly complicated example, as well as other stuff like 'see also'.

Description

fixed example and correctly updated information for the DOMActivate event

Motivation

Additional details

Related issues and pull requests

Fixed broken, overly complicated example, as well as other stuff like 'see also'.
@addsoupbase addsoupbase requested a review from a team as a code owner June 7, 2025 09:08
@addsoupbase addsoupbase requested review from wbamberg and removed request for a team June 7, 2025 09:08
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Jun 7, 2025
Copy link
Contributor

github-actions bot commented Jun 7, 2025

Preview URLs

(comment last updated: 2025-07-26 15:21:44)

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks great, but the example doesn't work for me in Firefox (it works in Chrome and Safari).

@Josh-Cena Josh-Cena changed the title fixed broken example fixed broken DOMActivate example Jul 26, 2025
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is already a great improvement, and I'm merging it just because it's removing this example that I'm long having a headache for. I've changed the wording to make it less assertive about the behavior, because I believe the spec actually requires detail to be 0, and non-zero values are non-standard.

@Josh-Cena Josh-Cena merged commit 99487ce into mdn:main Jul 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants