Skip to content

Add tests for EKS Fargate that validate kubelet API logging #37834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add tests for EKS Fargate that validate kubelet API logging #37834

wants to merge 7 commits into from

Conversation

justin-lesko
Copy link
Contributor

@justin-lesko justin-lesko commented Jun 10, 2025 •
edited
Loading

What does this PR do?

Adds e2e test coverage for logging via the Kubelet API by deploying an additional Nginx deployment on Fargate nodes.

Motivation

Test coverage for both the feature itself #35190 and the cluster-agent admission controller feature to enable Kubelet API logging on injected sidecars #37521.

Describe how you validated your changes

  • Tests are passing (pipeline referencing the proper test-infra-definitions commit hash)
  • I cloned the existing e2e test dashboard and added an Nginx Fargate section (autoscaling is out of scope)
Screenshot 2025-06-12 at 10 33 09 AM

Possible Drawbacks / Trade-offs

Additional Notes

BLOCKED on merging of DataDog/test-infra-definitions#1575

@justin-lesko justin-lesko added this to the 7.68.0 milestone Jun 10, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 10, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 0560e01

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${+0}$$ $${696.04}$$ < $${752.99}$$ $${-0.01}$$ $${176.02}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${+0}$$ $${694.26}$$ < $${751.36}$$ $${-0.04}$$ $${175.43}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${0}$$ $${358.56}$$ < $${369.68}$$ $${+0}$$ $${96.5}$$ < $${99.55}$$
✅ agent_msi $${+0}$$ $${959.85}$$ < $${987.01}$$ $${-0.02}$$ $${146.44}$$ < $${150.72}$$
✅ agent_rpm_amd64 $${+0}$$ $${696.03}$$ < $${752.98}$$ $${-0.04}$$ $${177.52}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${+0}$$ $${694.25}$$ < $${751.35}$$ $${+0.07}$$ $${177.42}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${-0}$$ $${685.98}$$ < $${739.42}$$ $${-0.01}$$ $${161.01}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${-0}$$ $${684.33}$$ < $${737.91}$$ $${-0.02}$$ $${160.06}$$ < $${170.22}$$
✅ agent_suse_amd64 $${+0}$$ $${696.03}$$ < $${752.98}$$ $${-0.04}$$ $${177.52}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${+0}$$ $${694.25}$$ < $${751.35}$$ $${+0.07}$$ $${177.42}$$ < $${189.81}$$
✅ agent_suse_arm64 $${-0}$$ $${685.98}$$ < $${739.42}$$ $${-0.01}$$ $${161.01}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${-0}$$ $${684.33}$$ < $${737.91}$$ $${-0.02}$$ $${160.06}$$ < $${170.22}$$
✅ docker_agent_amd64 $${+0.01}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_arm64 $${+0}$$ $${793.23}$$ < $${858.97}$$ $${+0}$$ $${255.97}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${+0.01}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_jmx_arm64 $${+0}$$ $${793.23}$$ < $${858.97}$$ $${+0}$$ $${255.97}$$ < $${274.36}$$
✅ docker_agent_windows1809 $${+0.01}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows1809_core $${+0.01}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows1809_core_jmx $${+0.01}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows1809_jmx $${+0.01}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows2022 $${+0.01}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows2022_core $${+0.01}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows2022_core_jmx $${+0.01}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows2022_jmx $${+0.01}$$ $${779.83}$$ < $${849.39}$$ $${+0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_cluster_agent_amd64 $${-0}$$ $${259.19}$$ < $${259.73}$$ $${+0}$$ $${102.88}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${-0}$$ $${273.58}$$ < $${274.24}$$ $${+0}$$ $${97.59}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${-0}$$ $${38.93}$$ < $${39.57}$$ $${+0}$$ $${14.95}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${-0}$$ $${37.52}$$ < $${38.2}$$ $${-0}$$ $${13.96}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${+0}$$ $${8.03}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.16}$$ < $${30.08}$$ $${+0}$$ $${6.98}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.04}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.04}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.48}$$ < $${60.17}$$ $${+0}$$ $${12.85}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.93}$$ < $${56.94}$$ $${-0}$$ $${11.14}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.51}$$ < $${56.41}$$ $${-0}$$ $${11.2}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.48}$$ < $${60.18}$$ $${-0}$$ $${12.86}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.94}$$ < $${56.94}$$ $${+0}$$ $${11.16}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.48}$$ < $${60.18}$$ $${-0}$$ $${12.86}$$ < $${15.84}$$

@justin-lesko justin-lesko mentioned this pull request Jun 12, 2025
Open
@justin-lesko justin-lesko marked this pull request as ready for review June 12, 2025 14:34
@justin-lesko justin-lesko requested review from a team as code owners June 12, 2025 14:34
@justin-lesko justin-lesko added the qa/no-code-change No code change in Agent code requiring validation label Jun 12, 2025
sblumenthal
sblumenthal approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@sblumenthal sblumenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So exciting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sblumenthal sblumenthal sblumenthal approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
qa/no-code-change No code change in Agent code requiring validation qa/skip-qa
Projects
None yet
Milestone
7.68.0
Development

Successfully merging this pull request may close these issues.
2 participants
@justin-lesko @sblumenthal