Skip to content

Update CODEOWNERS to transfer ownership to agent-build #37801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 10, 2025
Merged

Update CODEOWNERS to transfer ownership to agent-build #37801

merged 4 commits into from
Jun 10, 2025

Conversation

FlorentClarret
Copy link
Member

What does this PR do?

Update CODEOWNERS to transfer ownership to agent-build

Motivation

We split agent-delivery and agent-build

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jun 10, 2025
@FlorentClarret FlorentClarret added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jun 10, 2025
@FlorentClarret FlorentClarret requested a review from a team as a code owner June 10, 2025 09:02
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jun 10, 2025
@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ba492107-2b8d-452b-a4fb-d2d82a5b0c4b

Baseline: 0dfd2c5
Comparison: 4ac6040
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
✅ docker_containers_cpu % cpu utilization -5.22 [-8.89, -1.56] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ tcp_syslog_to_blackhole ingress throughput +0.96 [+0.91, +1.01] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.69 [+0.60, +0.79] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.60 [+0.55, +0.65] 1 Logs
➖ quality_gate_idle memory utilization +0.47 [+0.41, +0.52] 1 Logs bounds checks dashboard
➖ otlp_ingest_logs memory utilization +0.38 [+0.25, +0.51] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.29 [+0.11, +0.46] 1 Logs
➖ ddot_logs memory utilization +0.24 [+0.10, +0.38] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.05 [-0.50, +0.60] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.02 [-0.59, +0.62] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.58, +0.60] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.27, +0.28] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.01 [-0.58, +0.56] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.01 [-0.57, +0.55] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.61, +0.59] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.02 [-0.60, +0.56] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.05 [-0.28, +0.19] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.16 [-1.02, +0.70] 1 Logs
➖ file_tree memory utilization -0.36 [-0.52, -0.21] 1 Logs
➖ docker_containers_memory memory utilization -0.49 [-0.58, -0.40] 1 Logs
➖ ddot_metrics memory utilization -0.56 [-0.68, -0.45] 1 Logs
➖ quality_gate_logs % cpu utilization -2.63 [-5.31, +0.06] 1 Logs bounds checks dashboard
✅ docker_containers_cpu % cpu utilization -5.22 [-8.89, -1.56] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@FlorentClarret
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 10, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-10 10:50:39 UTC ℹ️ Start processing command /merge

2025-06-10 10:50:47 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-10 11:25:08 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 47m (p90).

2025-06-10 12:02:57 UTC ℹ️ MergeQueue: This merge request was merged

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 0dfd2c5

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${0}$$ $${696.04}$$ < $${752.99}$$ $${+0.01}$$ $${176.02}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${0}$$ $${694.26}$$ < $${751.36}$$ $${+0.01}$$ $${175.46}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${0}$$ $${358.56}$$ < $${369.68}$$ $${-0}$$ $${96.5}$$ < $${99.55}$$
✅ agent_msi $${0}$$ $${959.85}$$ < $${987.01}$$ $${-0}$$ $${146.46}$$ < $${150.72}$$
✅ agent_rpm_amd64 $${0}$$ $${696.03}$$ < $${752.98}$$ $${-0.01}$$ $${177.53}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${0}$$ $${694.25}$$ < $${751.35}$$ $${+0.03}$$ $${177.43}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${0}$$ $${685.98}$$ < $${739.42}$$ $${+0.02}$$ $${161.04}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${0}$$ $${684.32}$$ < $${737.91}$$ $${-0.02}$$ $${160.07}$$ < $${170.22}$$
✅ agent_suse_amd64 $${0}$$ $${696.03}$$ < $${752.98}$$ $${-0.01}$$ $${177.53}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${0}$$ $${694.25}$$ < $${751.35}$$ $${+0.03}$$ $${177.43}$$ < $${189.81}$$
✅ agent_suse_arm64 $${0}$$ $${685.98}$$ < $${739.42}$$ $${+0.02}$$ $${161.04}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${0}$$ $${684.32}$$ < $${737.91}$$ $${-0.02}$$ $${160.07}$$ < $${170.22}$$
✅ docker_agent_amd64 $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_arm64 $${-0}$$ $${793.23}$$ < $${858.97}$$ $${+0.01}$$ $${255.97}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_jmx_arm64 $${-0}$$ $${793.23}$$ < $${858.97}$$ $${+0.01}$$ $${255.97}$$ < $${274.36}$$
✅ docker_agent_windows1809 $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows1809_core $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows1809_core_jmx $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows1809_jmx $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows2022 $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows2022_core $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows2022_core_jmx $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_windows2022_jmx $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_cluster_agent_amd64 $${+0}$$ $${259.19}$$ < $${259.73}$$ $${-0}$$ $${102.88}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${+0}$$ $${273.64}$$ < $${274.24}$$ $${-0}$$ $${97.59}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${+0}$$ $${7.08}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${+0}$$ $${38.93}$$ < $${39.57}$$ $${-0}$$ $${14.95}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${0}$$ $${37.52}$$ < $${38.2}$$ $${-0}$$ $${13.96}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.03}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.16}$$ < $${30.08}$$ $${+0}$$ $${6.97}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.04}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.04}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.48}$$ < $${60.17}$$ $${+0}$$ $${12.85}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.93}$$ < $${56.94}$$ $${-0}$$ $${11.14}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.51}$$ < $${56.41}$$ $${-0}$$ $${11.21}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.48}$$ < $${60.18}$$ $${+0}$$ $${12.86}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.94}$$ < $${56.94}$$ $${+0}$$ $${11.16}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.48}$$ < $${60.18}$$ $${+0}$$ $${12.86}$$ < $${15.84}$$

@dd-mergequeue dd-mergequeue bot merged commit 67df56f into main Jun 10, 2025
222 checks passed
@dd-mergequeue dd-mergequeue bot deleted the FlorentClarret-patch-1 branch June 10, 2025 12:02
@github-actions github-actions bot added this to the 7.68.0 milestone Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chouetz chouetz chouetz approved these changes

@alopezz alopezz alopezz approved these changes

@kacper-murzyn kacper-murzyn kacper-murzyn approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Milestone
7.68.0
Development

Successfully merging this pull request may close these issues.
4 participants
@FlorentClarret @chouetz @alopezz @kacper-murzyn