Skip to content

AGTMETRICS-237 pre-aggregated sketches support #37034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

AGTMETRICS-237 pre-aggregated sketches support #37034

wants to merge 3 commits into from
+131 −50

Conversation

vickenty
Copy link
Contributor

@vickenty vickenty commented May 15, 2025 •
edited
Loading

What does this PR do?

Add support for pre-aggregated sketches to the dogstatsd no-agg pipeline.

Motivation

Possibly better throughput for clients that send a lot of distribution metrics.

Describe how you validated your changes

In addition to unit tests, run the test app to send identical set of points via direct sketch support and as older multi-valued distribution value. Verify that the two test metrics look identical for various aggregations in the app.

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/agent-metric-pipelines long review PR is complex, plan time to review it labels May 15, 2025
@vickenty vickenty changed the title Vickenty/dsk AGTMETRICS-237 pre-aggregated metrics support May 15, 2025
@vickenty vickenty changed the title AGTMETRICS-237 pre-aggregated metrics support AGTMETRICS-237 pre-aggregated sketches support May 15, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 15, 2025 •
edited
Loading

Uncompressed package size comparison

Comparison with ancestor b4cbb1d1bdb3f7c44dd1f2a424ef68b737f5e08f

Diff per package
package diff status size ancestor threshold
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 31.30MB 31.30MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 31.30MB 31.30MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 61.14MB 61.14MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 61.14MB 61.14MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 58.40MB 58.39MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB ✅ 31.22MB 31.21MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 61.06MB 61.06MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 58.31MB 58.31MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB ✅ 783.89MB 783.89MB 0.50MB
datadog-agent-x86_64-suse 0.00MB ✅ 783.89MB 783.89MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB ✅ 773.18MB 773.18MB 0.50MB
datadog-agent-amd64-deb 0.00MB ✅ 774.94MB 774.94MB 0.50MB
datadog-agent-arm64-deb 0.00MB ✅ 764.25MB 764.25MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 30.04MB 30.04MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB ✅ 378.71MB 378.71MB 0.50MB

Decision

✅ Passed

@vickenty vickenty added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels May 15, 2025
@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented May 15, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 47074e92-462f-455b-a7d4-7a512d1c6a67

Baseline: b6186a8
Comparison: f193364
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ uds_dogstatsd_to_api_cpu % cpu utilization +3.37 [+2.47, +4.27] 1 Logs
➖ docker_containers_memory memory utilization +0.90 [+0.81, +1.00] 1 Logs
➖ quality_gate_logs % cpu utilization +0.78 [-1.99, +3.55] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization +0.53 [+0.45, +0.62] 1 Logs bounds checks dashboard
➖ file_tree memory utilization +0.30 [+0.13, +0.46] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +0.25 [+0.19, +0.30] 1 Logs
➖ otlp_ingest_logs memory utilization +0.23 [+0.10, +0.36] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.08 [-0.46, +0.62] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.06 [-0.53, +0.66] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.04 [-0.50, +0.58] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.02 [-0.22, +0.25] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.01 [-0.61, +0.64] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.01 [-0.54, +0.55] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.00 [-0.26, +0.26] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.03, +0.02] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.01 [-0.59, +0.58] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.04 [-0.65, +0.58] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.09 [-0.25, +0.07] 1 Logs
➖ ddot_logs memory utilization -0.11 [-0.26, +0.03] 1 Logs
➖ ddot_metrics memory utilization -0.23 [-0.35, -0.12] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.66 [-0.71, -0.61] 1 Logs
➖ quality_gate_idle memory utilization -1.04 [-1.11, -0.97] 1 Logs bounds checks dashboard
➖ docker_containers_cpu % cpu utilization -1.58 [-4.51, +1.35] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 15, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor b6186a8

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${-0.03}$$ $${695.71}$$ < $${752.99}$$ $${+0.02}$$ $${175.95}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${-0.03}$$ $${693.92}$$ < $${751.36}$$ $${+0.01}$$ $${175.62}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${-0.03}$$ $${358.2}$$ < $${369.68}$$ $${-0.02}$$ $${96.44}$$ < $${99.55}$$
✅ agent_msi $${-0.02}$$ $${957.72}$$ < $${987.01}$$ $${-0.01}$$ $${146.16}$$ < $${150.72}$$
✅ agent_rpm_amd64 $${-0.03}$$ $${695.7}$$ < $${752.98}$$ $${+0.04}$$ $${177.52}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${-0.03}$$ $${693.91}$$ < $${751.35}$$ $${+0}$$ $${177.36}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${-0.05}$$ $${685.7}$$ < $${739.42}$$ $${-0.06}$$ $${160.85}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${-0.06}$$ $${684.05}$$ < $${737.91}$$ $${-0.05}$$ $${160.02}$$ < $${170.22}$$
✅ agent_suse_amd64 $${-0.03}$$ $${695.7}$$ < $${752.98}$$ $${+0.04}$$ $${177.52}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${-0.03}$$ $${693.91}$$ < $${751.35}$$ $${+0}$$ $${177.36}$$ < $${189.81}$$
✅ agent_suse_arm64 $${-0.05}$$ $${685.7}$$ < $${739.42}$$ $${-0.06}$$ $${160.85}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${-0.06}$$ $${684.05}$$ < $${737.91}$$ $${-0.05}$$ $${160.02}$$ < $${170.22}$$
✅ docker_agent_amd64 $${-0.03}$$ $${779.5}$$ < $${849.39}$$ $${-0.02}$$ $${268.44}$$ < $${288.34}$$
✅ docker_agent_arm64 $${-0.05}$$ $${792.95}$$ < $${858.97}$$ $${-0.05}$$ $${255.82}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${-0.03}$$ $${970.69}$$ < $${1040.59}$$ $${-0.02}$$ $${337.44}$$ < $${357.3}$$
✅ docker_agent_jmx_arm64 $${-0.05}$$ $${972.74}$$ < $${1038.77}$$ $${-0.03}$$ $${320.78}$$ < $${339.32}$$
✅ docker_agent_windows1809 $${-0.02}$$ $${1485.81}$$ < $${1557.19}$$ $${-0.02}$$ $${487.64}$$ < $${507.33}$$
✅ docker_agent_windows1809_core $${-0.02}$$ $${6215.77}$$ < $${6287.46}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows1809_core_jmx $${-0.02}$$ $${6337.34}$$ < $${6409.04}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows1809_jmx $${-0.02}$$ $${1607.44}$$ < $${1679.14}$$ $${-0.25}$$ $${529.89}$$ < $${550.27}$$
✅ docker_agent_windows2022 $${-0.06}$$ $${1505.11}$$ < $${1576.85}$$ $${-0.06}$$ $${500.37}$$ < $${520.76}$$
✅ docker_agent_windows2022_core $${-0.21}$$ $${6188.9}$$ < $${6260.53}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows2022_core_jmx $${-0.35}$$ $${6310.48}$$ < $${6382.17}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows2022_jmx $${-0.2}$$ $${1626.93}$$ < $${1698.2}$$ $${-0.05}$$ $${542.64}$$ < $${562.99}$$
✅ docker_cluster_agent_amd64 $${+0}$$ $${259.22}$$ < $${259.73}$$ $${-0.01}$$ $${102.89}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${+0.06}$$ $${273.65}$$ < $${274.24}$$ $${+0.01}$$ $${97.6}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${+0}$$ $${39.21}$$ < $${39.57}$$ $${+0}$$ $${15.11}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${+0}$$ $${37.88}$$ < $${38.2}$$ $${+0}$$ $${14.53}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${+0}$$ $${30.44}$$ < $${31.52}$$ $${+0}$$ $${8.0}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${+0}$$ $${29.01}$$ < $${30.08}$$ $${+0}$$ $${6.94}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${+0}$$ $${30.44}$$ < $${31.52}$$ $${+0}$$ $${8.0}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${+0}$$ $${30.44}$$ < $${31.52}$$ $${+0}$$ $${8.0}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${+0}$$ $${50.31}$$ < $${60.17}$$ $${+0}$$ $${12.81}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${+0}$$ $${47.79}$$ < $${56.94}$$ $${+0}$$ $${11.11}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${+0}$$ $${47.36}$$ < $${56.41}$$ $${+0}$$ $${11.17}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${+0}$$ $${50.31}$$ < $${60.18}$$ $${+0}$$ $${12.83}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${+0}$$ $${47.79}$$ < $${56.94}$$ $${-0}$$ $${11.13}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${+0}$$ $${50.31}$$ < $${60.18}$$ $${+0}$$ $${12.83}$$ < $${15.84}$$

@vickenty vickenty marked this pull request as ready for review May 16, 2025 07:53
@vickenty vickenty requested a review from a team as a code owner May 16, 2025 07:53
vickenty added 2 commits May 16, 2025 09:05
@vickenty
Refactor metric sample raw value to be bytes
9b3da00 
For client-aggregated sketches we will need to pass protobuf-encoded
values through the no-aggregation pipeline.
@vickenty
Support sketches in the no-agg pipeline
b34420c 
Dogstatsd server can now receive pre-aggregated sketches, and pass
them through no-aggregation pipeline to the serializer for sending to
the backend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-metric-pipelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vickenty