Skip to content

Allow RDS autodiscovery to discover all instances by specifying an empty tag list #37748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

Allow RDS autodiscovery to discover all instances by specifying an empty tag list #37748

merged 1 commit into from
Jun 9, 2025

Conversation

sethsamuel
Copy link
Contributor

@sethsamuel sethsamuel commented Jun 9, 2025 •
edited
Loading

What does this PR do?

Allows RDS Autodisovery to discover all instances if the user specifies an empty array for the AD tag list.

Motivation

Users may want to monitor all RDS instances without having to apply tags to trigger Autodiscovery. This can be useful for existing fleets where adding tags is a point of frustration, or for small fleets that can be easily monitored by a single agent.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@sethsamuel sethsamuel requested a review from a team as a code owner June 9, 2025 13:14
@sethsamuel sethsamuel added the qa/done QA done before merge and regressions are covered by tests label Jun 9, 2025
@sethsamuel sethsamuel changed the title Allow RDS autodiscovery to discover all instances by specifying an em… Allow RDS autodiscovery to discover all instances by specifying an empty tag list Jun 9, 2025
@github-actions github-actions bot added the medium review PR review might take time label Jun 9, 2025
@sethsamuel sethsamuel requested review from a team as code owners June 9, 2025 13:16
eric-weaver
eric-weaver reviewed Jun 9, 2025
View reviewed changes
@sethsamuel sethsamuel requested a review from eric-weaver June 9, 2025 13:35
@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jun 9, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 38c5eeb4-36ba-4603-9505-f6e66efa50c1

Baseline: cbd7198
Comparison: 74a514f
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +1.85 [-1.18, +4.88] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization +1.67 [+0.78, +2.55] 1 Logs
➖ docker_containers_memory memory utilization +0.90 [+0.83, +0.98] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +0.88 [+0.81, +0.94] 1 Logs
➖ ddot_metrics memory utilization +0.54 [+0.42, +0.66] 1 Logs
➖ file_tree memory utilization +0.27 [+0.14, +0.40] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.19 [+0.12, +0.26] 1 Logs bounds checks dashboard
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.13 [-0.44, +0.70] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.07 [-0.57, +0.70] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.02 [-0.22, +0.26] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.26, +0.28] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.01 [-0.56, +0.54] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.02 [-0.68, +0.64] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.06 [-0.64, +0.53] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.09 [-0.68, +0.49] 1 Logs
➖ ddot_logs memory utilization -0.12 [-0.26, +0.02] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.13 [-0.66, +0.40] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.34 [-0.50, -0.17] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.36 [-0.41, -0.31] 1 Logs
➖ quality_gate_logs % cpu utilization -0.54 [-3.27, +2.20] 1 Logs bounds checks dashboard
➖ otlp_ingest_logs memory utilization -0.69 [-0.82, -0.57] 1 Logs
➖ quality_gate_idle memory utilization -0.92 [-0.99, -0.84] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 9, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor cbd7198

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${0}$$ $${696.04}$$ < $${752.99}$$ $${+0.03}$$ $${176.05}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${-0}$$ $${694.26}$$ < $${751.36}$$ $${+0}$$ $${175.48}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${0}$$ $${358.56}$$ < $${369.68}$$ $${-0}$$ $${96.5}$$ < $${99.55}$$
✅ agent_msi $${-0}$$ $${959.85}$$ < $${987.01}$$ $${0}$$ $${146.46}$$ < $${150.72}$$
✅ agent_rpm_amd64 $${0}$$ $${696.03}$$ < $${752.98}$$ $${+0}$$ $${177.54}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${-0}$$ $${694.25}$$ < $${751.35}$$ $${+0.01}$$ $${177.41}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${0}$$ $${685.98}$$ < $${739.42}$$ $${-0.01}$$ $${161.04}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${0}$$ $${684.33}$$ < $${737.91}$$ $${+0.02}$$ $${160.09}$$ < $${170.22}$$
✅ agent_suse_amd64 $${0}$$ $${696.03}$$ < $${752.98}$$ $${+0}$$ $${177.54}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${-0}$$ $${694.25}$$ < $${751.35}$$ $${+0.01}$$ $${177.41}$$ < $${189.81}$$
✅ agent_suse_arm64 $${0}$$ $${685.98}$$ < $${739.42}$$ $${-0.01}$$ $${161.04}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${0}$$ $${684.33}$$ < $${737.91}$$ $${+0.02}$$ $${160.09}$$ < $${170.22}$$
✅ docker_agent_amd64 $${-0}$$ $${779.82}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
✅ docker_agent_arm64 $${0}$$ $${793.23}$$ < $${858.97}$$ $${-0.01}$$ $${255.96}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${-0}$$ $${779.82}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
✅ docker_agent_jmx_arm64 $${0}$$ $${793.23}$$ < $${858.97}$$ $${-0.01}$$ $${255.96}$$ < $${274.36}$$
✅ docker_agent_windows1809 $${-0}$$ $${779.82}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
✅ docker_agent_windows1809_core $${-0}$$ $${779.82}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
✅ docker_agent_windows1809_core_jmx $${-0}$$ $${779.82}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
✅ docker_agent_windows1809_jmx $${-0}$$ $${779.82}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
✅ docker_agent_windows2022 $${-0}$$ $${779.82}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
✅ docker_agent_windows2022_core $${-0}$$ $${779.82}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
✅ docker_agent_windows2022_core_jmx $${-0}$$ $${779.82}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
✅ docker_agent_windows2022_jmx $${-0}$$ $${779.82}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
✅ docker_cluster_agent_amd64 $${+0}$$ $${259.19}$$ < $${259.73}$$ $${+0}$$ $${102.88}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${+0.07}$$ $${273.64}$$ < $${274.24}$$ $${+0}$$ $${97.59}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${-0}$$ $${38.93}$$ < $${39.57}$$ $${-0}$$ $${14.95}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${0}$$ $${37.52}$$ < $${38.2}$$ $${+0}$$ $${13.96}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.03}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.16}$$ < $${30.08}$$ $${-0}$$ $${6.97}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${+0}$$ $${8.04}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${+0}$$ $${8.04}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.48}$$ < $${60.17}$$ $${-0}$$ $${12.85}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.93}$$ < $${56.94}$$ $${+0}$$ $${11.14}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.51}$$ < $${56.41}$$ $${+0.01}$$ $${11.21}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.48}$$ < $${60.18}$$ $${+0}$$ $${12.86}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.94}$$ < $${56.94}$$ $${-0}$$ $${11.16}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.48}$$ < $${60.18}$$ $${+0}$$ $${12.86}$$ < $${15.84}$$

@sethsamuel sethsamuel force-pushed the seth.samuel/DBMON-5443-allow-rds-autodiscovery-with-no-tags-to-select-all-instances branch from dcea27d to 74a514f Compare June 9, 2025 16:16
cswatt
cswatt approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release notes approved for docs 👍

@sethsamuel
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 9, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-09 19:01:19 UTC ℹ️ Start processing command /merge

2025-06-09 19:01:25 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 47m (p90).

2025-06-09 19:44:24 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 1548630 into main Jun 9, 2025
237 checks passed
@dd-mergequeue dd-mergequeue bot deleted the seth.samuel/DBMON-5443-allow-rds-autodiscovery-with-no-tags-to-select-all-instances branch June 9, 2025 19:44
@github-actions github-actions bot added this to the 7.68.0 milestone Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cswatt cswatt cswatt approved these changes

@eric-weaver eric-weaver eric-weaver approved these changes

Assignees
No one assigned
Labels
medium review PR review might take time qa/done QA done before merge and regressions are covered by tests
Projects
None yet
Milestone
7.68.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sethsamuel @cswatt @eric-weaver