vendor: bump lxml to >4.6.4,<5.0 #4143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove the compat wheel installs on Windows for the CI runners, as lxml 4.6.4 has fixed the missing python 3.10 wheels https://pypi.org/project/lxml/4.6.4/#files
bastimeyer
added
dependencies
os: Windows
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove the compat wheel installs on Windows for the CI runners, as
lxml 4.6.4 has fixed the missing python 3.10 wheels
https://pypi.org/project/lxml/4.6.4/#files
Resolves #4100
The version requirement got bumped to ensure that everyone's up2date and will be able to find a matching wheel download, even though it's not strictly necessary. The lxml changes themselves are irrelevant for Streamlink.
https://github.com/lxml/lxml/blob/lxml-4.6.4-5/CHANGES.txt
I've also added the less than 5.0 constraint because we should do that on all dependencies, to prevent issues when breaking changes in dependencies are introduced. I will update the version of the websocket-client requirement once I'm done with my new websocket implementation. The other ones will need further review.