-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
plugins.afreeca: support metadata #5849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins.afreeca: support metadata #5849
Conversation
great thanks! you are so fast!!! |
No problem... Let me give some assistance. The plugin isn't very well maintained and its code is rather old. Your changes are fine for a quick fix (we don't have to refactor/rewrite the plugin for this), apart from two issues:
|
Btw, |
Checking the metadata of a random channel from your branch:
|
I meant changing it to the |
Using the broadcast number from the JSON data is also fine... Please also add the metadata to the plugin module metadata at the top: diff --git a/src/streamlink/plugins/afreeca.py b/src/streamlink/plugins/afreeca.py
index 364dc6fb..22ee99f0 100644
--- a/src/streamlink/plugins/afreeca.py
+++ b/src/streamlink/plugins/afreeca.py
@@ -2,6 +2,9 @@
$description TV and live video game broadcasts, artist performances and personal daily-life video blogs & shows.
$url play.afreecatv.com
$type live
+$metadata id
+$metadata author
+$metadata title
"""
import logging |
BJID is also unique. BNO is updated every time the streamer turns on the broadcast. omg I made a mistake with this commit... |
Thanks, should be fine now... Plugin metadata is properly documented: merging... |
Sorry, but there's a suggestion, can you add the English username of the streamer to the metadata? It's "jjllyy", and I want to use the English name as the file name for easy identification (I don't know Korean), and this English name is also unique |
How about sideloading a modified plugin or using an English ID based on URL? |
OK, just finish. thanks! |
Resolves: #5813
I don't know if it's right to handle it this way.
Nickname and title written in Korean are displayed as Unicode.
I'm not very familiar with python so I don't know how to handle this.