Return transaction from upgrade a database #458
Conversation
stelar7
force-pushed
the
database-upgrade-adjustment
branch
from
4352ded to
11bb776
Compare
|
|
||
| 1. If |connection| was [=connection/closed=], | ||
| return a newly [=exception/created=] | ||
| "{{AbortError}}" {{DOMException}} and abort these steps. | ||
|
|
||
| 1. If the [=/upgrade transaction=] was aborted, run the steps |
There was a problem hiding this comment.
I don't think you need to return a value from upgrade a database as the request's transaction will be set to the transaction, although only if it succeeded. If it was aborted, the request's transaction will be null and done flag will be false. So this can change to something like "If |request|'s [=request/transaction=] is null, run the steps to..."
There was a problem hiding this comment.
Thanks for this analysis, @evanstade. Agreed - I think this recommendation is sufficient. Even easier than what I recommended over in #433 (comment)
There was a problem hiding this comment.
I might be wrong here, but I dont think thats correct. The upgrade transaction has to "finish" before we can stop spinning during upgrade. (and afaik, only commit/abort will finish.) As part of commiting, the requests transaction is cleared (since we are an upgrade transaction). This means that at this point it should be null in all cases?
Some work towards fixing the issues mentioned in #433
The following tasks have been completed:
Implementation commitment:
Preview | Diff