Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: webfactory/slimdump
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.14.0
Choose a base ref
...
head repository: webfactory/slimdump
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.14.1
Choose a head ref
  • 4 commits
  • 15 files changed
  • 1 contributor

Commits on Oct 25, 2022

  1. Configuration menu
    Copy the full SHA
    10affd0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b8e7948 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Configuration menu
    Copy the full SHA
    000e2df View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Dump TRIGGER definitions _after_ data (#100)

    When the new CSV output mode with the concept of "output drivers" was added in #92, dumping `TRIGGER` definitions was made an implementation detail of the MySQL output driver. This caused `TRIGGER` definitions to be dumped right after the `CREATE TABLE ...` commands, before the actual data `INSERT` statements.
    
    This potentially breaks the generated SQL files, since a newly created trigger may be relevant for the subsequent `INSERT` statements; however, MySQL requires that tables used in the trigger are also included in the `LOCK TABLES` statements.
    
    The aim of this PR is to revert that change, i. e. to dump trigger definitions for a table _after_ the data insert statements for it.
    
    I think it is not necessary to move all trigger definitions to the very end of the output – that is, after _all_ tables have been created and filled with data: A trigger depends on insert/update/deletes for a particular table and is executed only on these events. So, it is not a problem if a trigger refers to a table that has not been created/loaded yet as long as the trigger is not run (and avoiding to run it is the aim of this PR).
    mpdude authored Dec 21, 2022
    Configuration menu
    Copy the full SHA
    481b94a View commit details
    Browse the repository at this point in the history
Loading