Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: webfactory/slimdump
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.15.0
Choose a base ref
...
head repository: webfactory/slimdump
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.15.1
Choose a head ref
  • 3 commits
  • 15 files changed
  • 1 contributor

Commits on Jan 18, 2024

  1. Fill in dummy types to deal with DC2:... column comments (#102) 

    We're using the `SchemaManager` to simplify listing tables, views and so
on. But, the information provided by it also includes the DBAL types
used for columns, and that information may be parsed from column
comments in the database.

The problem is that a table definition like so:

```sql
CREATE TABLE `test` (
  `some_col` int NOT NULL COMMENT '(DC2Type:some_type)'
)
```

... `slimdump` fail fail with an exception because it does not know
about the `some_type`. This type may be available and defined in your
application, but we cannot put it into the `slimdump` command.

Now, in fact, we don't care about the type and its conversion
capabilities at all. So, this PR adds a runtime "just in type"
registration of a `DummyType` that serves as a placeholder to avoid
issues when loading the schema.

Fixes #96.
    @mpdude
    mpdude authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    02315a3 View commit details
    Browse the repository at this point in the history

  2. Update to use actions/checkout v4 (#105)

    @mpdude
    mpdude authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    d91e8b5 View commit details
    Browse the repository at this point in the history

  3. Update GHA workflows to use current Ubuntu and tools versions (#106)

    @mpdude
    mpdude authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    dcae8af View commit details
    Browse the repository at this point in the history
Loading